From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 15:58:02 2022 Received: (at 57122) by debbugs.gnu.org; 10 Aug 2022 19:58:02 +0000 Received: from localhost ([127.0.0.1]:50822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLrq5-0005uE-JB for submit@debbugs.gnu.org; Wed, 10 Aug 2022 15:58:01 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:35539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLrq2-0005tu-Br for 57122@debbugs.gnu.org; Wed, 10 Aug 2022 15:57:59 -0400 Received: by mail-ej1-f65.google.com with SMTP id a7so29661708ejp.2 for <57122@debbugs.gnu.org>; Wed, 10 Aug 2022 12:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:from:to:cc; bh=oGEafigTTs00cod52urAjXfd6gj3t7k/MIIyc2UwMkU=; b=ZwHubhUbzcfJJN2lok00sm/C5CCZs4Wtpf/zuxmR39gKjRk93JAqtL4RC3lti5xyo4 FS28WVtlnp1onICQQ1Y7OtU6l5IOme/+AnQcwkBJ9NtE6Ez/pn2CzK0cmX61D+RlX6y4 jQqDba2oh+3a5ZUelg/wyfVYFOKxhDfo9edFmn1JKrkXCbOfI7K6Tg/EC/LmBw0+bBED pWvvsgd2Uk42VYKedq6mLQaoxKjTpF5zp5QKLosT05sB73+IDaUSaLQSuv2dJUrx3h68 ZbCsE9UGyQvTKlm4MG/T1mMvNhroOWqdItbaxust1oH1614TIg15QsD+18MoniSCAD3y Gfmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc; bh=oGEafigTTs00cod52urAjXfd6gj3t7k/MIIyc2UwMkU=; b=pOUma5+aS5rlhODy4L4KOFiKZsMWwakzzZf2PanHtTYYJrSRohWWCS4FtxdlO1pAI+ o8yyvDENIxfxnEC6x8KRayOgoJ/egVGI3H8rpIKMQC3/uzgoTG0pHaRl/5tTi1EDGNii ZUbBZ0TFuzRzgqTrdo12QdlBoYV4soMTfGy1cKe9L4zzdo4QrYAMcYT9pWLhtA5Oc11W aaqJqSjckSZMHbIqPF/dgAfzCAHGzIkPLipOufDti2RxYlVwLiEQwFt72QzTCFGkqTGC x8TO2ahVW1wK5SNSDvKke4TwqF/SG9nyUSlVlYPqhSbpIaMrZL1FdV0TTyQNLZVq0KWd OW4g== X-Gm-Message-State: ACgBeo1z/3k1MEOwWP3GPMfUv6/snW2yn4XJOyy6Hxym47fu/iHGfzJz nJZ66pKaLCaWICjXMrvbXyc= X-Google-Smtp-Source: AA6agR5a0qSnaVLVNw5vb3MHbT1168/gaXsOTK8IqFb3VM7XvOPuiae64nTj/aALBcKr+Uin/QD0+w== X-Received: by 2002:a17:906:ef8c:b0:730:e4e0:1f69 with SMTP id ze12-20020a170906ef8c00b00730e4e01f69mr20083202ejb.113.1660161472331; Wed, 10 Aug 2022 12:57:52 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id w21-20020a170906131500b0072ab06bf296sm2625984ejb.23.2022.08.10.12.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 12:57:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH] build-system: emacs: Use new function for autoloads generation From: Liliana Marie Prikler To: Morgan.J.Smith@outlook.com, 57122@debbugs.gnu.org Date: Wed, 10 Aug 2022 21:57:51 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 57122 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 10.08.2022 um 13:37 -0400 schrieb Morgan.J.Smith@outlook.com: > From: Morgan Smith > > * guix/build/emacs-utils.scm (emacs-generate-autoloads): Use > 'loaddefs-generate' to create autoloads instead of > 'update-directory-autoloads' if we are using a new enough Emacs > --- > > I'm not sure how long it takes to rebuild all the Emacs packages so I > CC'd Liliana since they are going to change the Emacs build system > soon anyways. I can tack that onto native-comp no problem. I can't recall the time it took to rebuild everything for the last big upgrade, but it's definitely something to do for fun and a little heat in winter. > This change is to allow packages to be built with the latest commits > of emacs (guix build emacs-crdt --with-input=emacs-minimal=emacs-next > --with-latest=emacs-next) > > Just last week the 'update-directory-autoloads' function got > deprecated and replaced.  Since continuing to use the deprecated > function would require changes anyways (adding a '(require > 'autoloads)' would do it I think), I decided to just use the newer > function. > > Is this a bug in upstream Emacs where autoloaded functions like > 'update-directory-autoloads' don't get autoloaded when they are in > the obsolete directory?  Possibly.  Is this a bug related to our > packaging of Emacs?  Possibly.  Is this the intended behaviour?  > Possibly.  I'm not the guy to ask :P. I'm really not sure why this > stopped working.  But we will have to switch to the 'loaddefs- > generate' function eventually anyways so I think this patch is > probably good to apply. Can we instead use make-directory-autoloads or has that also been deprecated in 29? make-directory-autoloads exists since Emacs 28.1 and seems to have the same signature as loaddefs-generate. Any reason to prefer the latter? Cheers