From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 04:53:45 2022 Received: (at 57021) by debbugs.gnu.org; 12 Aug 2022 08:53:45 +0000 Received: from localhost ([127.0.0.1]:55614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMQQL-0003g7-CR for submit@debbugs.gnu.org; Fri, 12 Aug 2022 04:53:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMQQK-0003fv-1e for 57021@debbugs.gnu.org; Fri, 12 Aug 2022 04:53:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMQQD-0008PL-O2; Fri, 12 Aug 2022 04:53:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=G837slC8gtZ8CtqKOiTwQ6PNzfljb+HfUZBVDdcj3gI=; b=dnw0UgyoPpjLOplvkZsq S/j2+4eMrSKuagqBWlvfF5bZsE/ud5zzU8HWtLUtCyMi3YuqM303BpHlFxrbVwzupGJx0QzTbU91M ruFu7opOO7WwYxglrpHFJrt1iGpmf/15bZL/dKacli3BjDs6hi6CHj8zwCBn6VA3SDZQlxGNJgb6Y Ajgag18HX//PbD+EG4JSr3QPuLbhSEARg0mT6FNC0B7Xb/VJMuynS56Ek6ATnjttH8/AjLyhrRxxQ ADT2+aq0XBXNQEadwAkGvAulqN7QaXNiMjScyIiHH2z3uqZzhhzTPTA9sxNaCOGbOfAHI0jp7nLyD FyUFHH2T0MS3fg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:41976 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMQQD-0002iP-5Q; Fri, 12 Aug 2022 04:53:37 -0400 From: Mathieu Othacehe To: M Subject: Re: bug#57021: [PATCH] gnu: packages: Add nmail. References: Date: Fri, 12 Aug 2022 10:53:33 +0200 In-Reply-To: (M.'s message of "Sun, 7 Aug 2022 01:02:07 +0200") Message-ID: <8735e1267m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57021 Cc: 57021@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > * gnu/packages/nmail.scm: Reorder module imports. Remove > duplicate imports. > (nmail): New variable. Fix style. Thanks for this first contribution. As you are adding a new package, the preferred way to proceed is to amend your first patch with those changes and submit a new revision (v2). The module re-ordering stuff should also be part of a new patch. In short, we would expect something like: * gnu: Reorder mail module imports. * gnu: nmail: New variable. Do you think you could send those two patches in a v3? Don't hesitate to ask for guidance here or on IRC if I'm unclear. Mathieu