From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 28 10:59:02 2022 Received: (at 56799) by debbugs.gnu.org; 28 Jul 2022 14:59:02 +0000 Received: from localhost ([127.0.0.1]:59250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4yc-0000Ml-4g for submit@debbugs.gnu.org; Thu, 28 Jul 2022 10:59:02 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:45006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4yZ-0000MH-KO for 56799@debbugs.gnu.org; Thu, 28 Jul 2022 10:59:00 -0400 Received: by mail-qt1-f179.google.com with SMTP id r21so1272278qtn.11 for <56799@debbugs.gnu.org>; Thu, 28 Jul 2022 07:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Nwzoq23udU6iZmt19b3tuMkIXtqoLFht7y8DWx9YTjw=; b=VGrsfLa70MJab+2fHO5u19868TDfVaFv6nFbg2uYoaySANI/gmyTcgwlktlJ58swdX dmNZH7WAA7L0c+12By//9bVZVIBDyv4McymouJU21nBsJrqsVpcDyfgmnIyhu7bnf7zt Ypgjc1pv0QwVPHXpIZ9DKWsvFdLorpOqGRGr9APRpHMsmXIWxq/SiNhEzw7DiqqEXAQb UNMBLLc5w2svhpHmj/xsu4S7Kt7+H1Flj0N1SI7rhmCxtUXp1JU1dTq5a+IWleudP/JT m04gH/aHEyOoL0Psu9DooCoKdAp6q+2tiV19zfOZ8ibXC26fj6E7erq+uozwf6TqmYk+ /SOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Nwzoq23udU6iZmt19b3tuMkIXtqoLFht7y8DWx9YTjw=; b=ZXm+1hYU2pLz2xdi/ns8RCUEUC6pRF6IwtMPLBFJ76oc3E/adS29S33myex3xBqEEw nvvba9jgLstvJE5U3bxAtsrlKD1BYFQ/TwFN1uOIPhPV73yQHEzCZwcYeSobpXuEox6T Tj6mZc1JAQpduy5WI2ccGRVBjgHsz37bjb7FR0e1w+sjueuYfm7Um04mvNt7P0rTw4/d d1AQgeVKR4o9u+eU5IXjzGUIE1XIKEBaD3MqoOohAlzr06pEt+3444EHJqyAgkMeE8Yv Ue4Pb5NUc/H2/9uEsuDu/YBaHXA3CzY/kCHxZ7nHPdTEpfwRyp0Jz3d3m4FtPN30iNA/ ubng== X-Gm-Message-State: AJIora8l0QpRnWHrboyva1sjfP76bbFT3qu+HBc1unuZjMOtaXaPKZx3 9hTErfPT3py4w7PXGmWaTliOo0TvsEk= X-Google-Smtp-Source: AGRyM1sXeMA3ZnTJlRSLtQC83w+HbbJWICUw7H+fTNOmmVma6afs7sVLBKBxqUz7lkz2dgY45pq8Dw== X-Received: by 2002:ac8:5d94:0:b0:31f:1e7b:7d9b with SMTP id d20-20020ac85d94000000b0031f1e7b7d9bmr22487915qtx.205.1659020333746; Thu, 28 Jul 2022 07:58:53 -0700 (PDT) Received: from hurd (dsl-10-148-58.b2b2c.ca. [72.10.148.58]) by smtp.gmail.com with ESMTPSA id d7-20020a05620a240700b006a3325fd985sm675968qkn.13.2022.07.28.07.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 07:58:53 -0700 (PDT) From: Maxim Cournoyer To: Maxime Devos Subject: Re: bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input. References: <877d3y8hjj.fsf@gmail.com> <20220727202010.16970-1-maxim.cournoyer@gmail.com> <16e2cf89-bbfb-6336-0249-6af68afa3109@telenet.be> Date: Thu, 28 Jul 2022 10:58:52 -0400 In-Reply-To: <16e2cf89-bbfb-6336-0249-6af68afa3109@telenet.be> (Maxime Devos's message of "Wed, 27 Jul 2022 23:43:55 +0200") Message-ID: <87r125707n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56799 Cc: 56799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxime Devos writes: > On 27-07-2022 22:20, Maxim Cournoyer wrote: > >> Fixes . >> >> * guix/gexp.scm (gexp->sexp)[*unspecified*]: Quote value when encountering it. > > I recommend writing a test case -- this patch does not actually do that. > > Instead, it returns the symbol x. > > In a ./pre-inst-env guix repl: > >> scheme@(guix-user)> ,use (guix) >> scheme@(guix-user)> ,m (guix gexp) >> scheme@(guix gexp)> ,enter-store-monad >> store-monad@(guix gexp) (gexp->sexp #~(list #$*unspecified*) >> "x86_64-linux" "aarch64-linux-gnu") >> $1 = (list x) > I don't know what exact semantics you had in mind but probably not this. Indeed. Fixed in v3 (which includes a test). Thanks! Maxim