From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 17:41:50 2022 Received: (at 56297) by debbugs.gnu.org; 4 Jul 2022 21:41:50 +0000 Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpF-0002a4-Tk for submit@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8TpE-0002Zq-IT for 56297@debbugs.gnu.org; Mon, 04 Jul 2022 17:41:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp9-00072B-8W; Mon, 04 Jul 2022 17:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=k/nR/qCRx0ZFNOGKrTNsgXQn+8HRD6XGsJvWOkxPKdY=; b=cupwe1Q+tkDgGZnyIDB0 BRrB6h2Sce/j6wXsGJgUehFxnv8KKEGQXKBmJbcmlDTcl0whO/qp75L4Hvbgy5im6h5ZrmjZCfuRB xmFg81QfhazG6QwGYKiMco42zuJCpXa5+DcDAUH5a784FYA5ZCkRCvy93OSq5zmU7fLDtXtZyi0px wkmDkbo/CenMFrGv5yUvRDQqqC+z/K0Owc2ZVtzsNf+X8LApnJz8xqU3ZJtBMBT6Lb06c+Llz8d3m 8nbuI8KTinmvvwgdZcD2O2bW62LAnIJDdRh2Zg5h5KHiNNz/bdYqUcKLqLTrhGmANNzvq2CNsnJ4b gYhiS/pNhT05bA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54762 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Tp8-0003hG-S9; Mon, 04 Jul 2022 17:41:43 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#56297: Guix style imperfections References: <9499300db3fe4222f7126240fb2acad3cdf4371b.camel@telenet.be> <87sfnj259y.fsf@gnu.org> Date: Mon, 04 Jul 2022 23:41:40 +0200 In-Reply-To: <87sfnj259y.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 02 Jul 2022 12:11:21 +0200") Message-ID: <87mtdo7dyj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56297 Cc: 56297@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ludovic Court=C3=A8s skribis: >>> (define-public guile-next >>> (let ((version "3.0.7") (revision "0") >>> (commit "d70c1dbebf9ac0fd45af4578c23983ec4a7da535")) >> >> Conventionally 'revision' is put on another line -- for these kind of le= t bindings, >> (maybe all?), I would recommend to put all of them on separate lines. > > This one is a bug IMO: =E2=80=98let=E2=80=99 bindings should be treated s= pecially, and > currently they=E2=80=99re not. Commit 8d9291bd2c36810be50ea340cefa481a42c60a2b fixes this, and=E2=80=A6 >>> (substitute-keyword-arguments (package-arguments guile-3.0) >>> ((#:phases phases >>> '%standard-phases) `(modify-phases ,phases >> >> Put %standard-phases on the same line ad #:phases phases and `(modify-ph= ases ,phases >> on a new lineg=20 =E2=80=A6 the second part of this one. Ludo=E2=80=99.