From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 25 08:15:14 2022 Received: (at 56213) by debbugs.gnu.org; 25 Jun 2022 12:15:14 +0000 Received: from localhost ([127.0.0.1]:44326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54h0-000730-0O for submit@debbugs.gnu.org; Sat, 25 Jun 2022 08:15:14 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o54gx-0006tZ-1S for 56213@debbugs.gnu.org; Sat, 25 Jun 2022 08:15:12 -0400 Received: by mail-lf1-f47.google.com with SMTP id t25so8799003lfg.7 for <56213@debbugs.gnu.org>; Sat, 25 Jun 2022 05:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cl5z/xI4HYDmrdselQegONCJByH2b8Ja+ULN25GCNQA=; b=KzWyO9DgyiUdZGmTok8fFdqTcmhXncZhXjlBOZXlXnbRoVBPUO5vNT5rVjAsryFC8B JxpXCwy2eS5gdXzrHpLDhS1wgbezzXXeeq1AaWTjY4IyV/az5GJFcJvo4jO1Nq/WCr+c oM1SwstbXHbyEJapJFhqAtdluwwa10nyviq0/DFAnQyY9kjf/Igq6WI0Bvy6X6AN7UEr uRwkNCbt7qYdt/+jn3WEkRIYHQCP4vAWLfsZs4Nsl/DOh2jFpFs3mAOleFFeP3AaMxlu oUYpIfLR+IrIMKDXA8iMFgiSKY5+lQs+8CvQzenO8JHGRuXCavxxBLFksyibOKWmta/n SnIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cl5z/xI4HYDmrdselQegONCJByH2b8Ja+ULN25GCNQA=; b=VlsNKHLpQhFoPPK0Zl/DCcswEJpRq0UtPpHCGRleAQXGc1iykCq3iN4f5jgZ0ZZySl 2d6ajS0dXJKaG0fFMjrvVVnGFp3qMGIKQ9A0paI7nWOlOFiZX/jBqgYJDS9HaEBy/Trc cmv888Ngjx8FSMyihZxaamuGiJhWppmslzJ8EnlAVXvoahR4kUQGT1pDBFx9qdRl9meS MFDTKfbeuC/oh2FPijEwOCJpXuWW2/jXtpgDlTOGFasOw/jAhZv2SIysVfTWHA9yGQ0S eTVaUP9s76FlOr/SMcgzcpQlFdB72SR8U7RC0wQfqJZ+IP877gEXWod0zvoKVNmaus/y 1wuQ== X-Gm-Message-State: AJIora9HliXjRFY0xcxCJorbyhY8OLHapijxbhEiW7SMpQam7eodjYIe O9TN1LTuXzxjAkE7oWHvjH0XlIsEPoE= X-Google-Smtp-Source: AGRyM1ubKZqLMn+sBP9GvqcuPDrzNTggQ1X13uo7rczAbhK7I7EbE75orB7uqwO45tG/psE0tWG70A== X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr2235418lfa.442.1656159302986; Sat, 25 Jun 2022 05:15:02 -0700 (PDT) Received: from elephant ([5.164.222.47]) by smtp.gmail.com with ESMTPSA id a19-20020ac25e73000000b0047255d21205sm829875lfr.308.2022.06.25.05.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 05:15:02 -0700 (PDT) From: "Artyom V. Poptsov" To: Julien Lepiller Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core References: <878rplniny.fsf@gmail.com> <20220625132117.6da69dda@sybil.lepiller.eu> Date: Sat, 25 Jun 2022 15:14:58 +0300 In-Reply-To: <20220625132117.6da69dda@sybil.lepiller.eu> (Julien Lepiller's message of "Sat, 25 Jun 2022 13:21:17 +0200") Message-ID: <87wnd52b3x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56213 Cc: 56213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello Julien. > Thanks for the patch! Thanks for taking your time for reviewing my patch. :-) > Missing full stop at the end of the subject line. Okay, added a full-stop. FWIW, I'm usually following those rules when writing commit messages: https://cbea.ms/git-commit/#end The rules explicitly say that a committer should not add a full-stop at the end of the first line. > This package actually has tests, could you enable them? Unfortunately tests require JUnit5. :-/ > The pom file references most of these as runtime dependencies, so we > need to propagate them, so maven can find them. > We also need to propagated the parent pom :) Done. However, 'guix lint' gave me the following warning: --8<---------------cut here---------------start------------->8--- /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2: maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 and plexus-parent-pom@4.0 collide --8<---------------cut here---------------end--------------->8--- I don't know yet how to properly fix that; probably the issue is that I made all the inputs propagated, but I don't see how to differentiate them looking at the Doxia Core 'pom.xml'. > This feels like a description of the whole Doxia project. Could you add > maybe one sentence to explain how this package is related to the whole > doxia project? Done. > Lastly, I would put this package just below maven-doxia-parent-pom, but > that's mostly aesthetic :) Done. Please find the updated patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-gnu-Add-maven-doxia-core.patch Content-Transfer-Encoding: quoted-printable From=20749617e6c68d11edea3437cc72dc74013e851463 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Sat, 25 Jun 2022 13:20:02 +0300 Subject: [PATCH] gnu: Add maven-doxia-core. * gnu/packages/maven.scm (maven-doxia-core): New variable. =2D-- gnu/packages/maven.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index e5831ee614..514ba97028 100644 =2D-- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -3938,3 +3938,32 @@ method and a end of tag by @code{xxxx_()} method.") (description "@samp{Doxia} is a content generation framework that prov= ides powerful techniques for generating static and dynamic content, supporting a variety of markup languages."))) + +(define-public maven-doxia-core + (package + (inherit maven-doxia-sink-api) + (name "maven-doxia-core") + (arguments + `(#:jar-name "doxia-core.jar" + #:source-dir "doxia-core/src/main/java" + #:test-dir "doxia-core/src/test/java" + #:tests? #f ; tests require JUnit5 + #:phases (modify-phases %standard-phases + (replace 'install + (install-from-pom "doxia-core/pom.xml"))))) + (propagated-inputs (list maven-doxia-parent-pom + maven-doxia-sink-api + java-slf4j-api + java-javax-inject + java-plexus-utils + java-eclipse-sisu-plexus + java-commons-text)) + (home-page "https://maven.apache.org/doxia/index.html") + (synopsis "Doxia core classes and interfaces") + (description + "Doxia is a content generation framework that provides powerful +techniques for generating static and dynamic content, supporting a variety= of +markup languages. + +This package contains Doxia core classes and interfaces.") + (license license:asl2.0))) =2D-=20 2.25.1 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D Artyom =2D-=20 Artyom "avp" Poptsov Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE0MLqwTMQgi2Y3rV86cWi2QiYoC8FAmK2/EIACgkQ6cWi2QiY oC+sLAf/db+yzh7K53598Sv2LkHUVmWvi4IxROCp7R8THRWGuk0KKFpHBBsIhFMB 6TvnXBbuKJw4giMDmA8gUEvTdMyirFsohsGheUvet5hHl0x+u1e24fTJryNaqcbL DEqDvhWEPOLk3ULW+21NMBMJgiHk9A+TCaa0/mqNkWcsNx9QL5GbB7KzpW2tjggV JVq1tCK4qSyBrfhlnkgDdHGOTttClS8+cdLKY7GKUDIk57EXudYZ6gdCKToVL0Wq OHPVwCYECI12WbtPf8rxP9NP8+JclK7LoKQ4mpjSySPhOH1x3Ao23I8u7TEBv6Rj 1gN8p+Br5oDVcJvapeXPxORkDcgE6A== =KGco -----END PGP SIGNATURE----- --==-=-=--