From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 16:17:51 2022 Received: (at 56057) by debbugs.gnu.org; 18 Jun 2022 20:17:51 +0000 Received: from localhost ([127.0.0.1]:50220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2etD-0002Zl-FV for submit@debbugs.gnu.org; Sat, 18 Jun 2022 16:17:51 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2etB-0002Zc-G1 for 56057@debbugs.gnu.org; Sat, 18 Jun 2022 16:17:50 -0400 Received: from [172.20.10.9] ([188.188.170.162]) by baptiste.telenet-ops.be with bizsmtp id kkHm2700L3Waito01kHnCT; Sat, 18 Jun 2022 22:17:47 +0200 Message-ID: <829df0f0a945554d749c9dfbcf2524da281903c4.camel@telenet.be> Subject: Re: [bug#56057] [gnu: Add dua-cli. 23/27] gnu: Add rust-clap-derive-3. From: Maxime Devos To: antlers , 56057@debbugs.gnu.org, antlers@luris.net Date: Sat, 18 Jun 2022 22:17:42 +0200 In-Reply-To: <20220618195656.10108-24-antlers@luris.net> References: <20220618195656.10108-1-antlers@luris.net> <20220618195656.10108-24-antlers@luris.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-i+bk06/ZF/Hb2ZEkFiWO" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655583467; bh=XtbqYf5i8cJtSsxnq5mCikkGg+kZwNd+et+R+P7szm8=; h=Subject:From:To:Date:In-Reply-To:References; b=nPplZ5N0DFY59lQNaphwOrsjEoE40r5OeOdNbxnasrPE3oSYLOaOgbIkFut8NjL6z hq+56ayui7FfuZRcSBax/FeV8iZcnRnIzCDWxUCatzHy0ZQPmVSeIcGsNxzzimPfqX SOr7G+jCcMD50IdDPCml+R14vm1C6inSPCsOVb0o5rGivY+qp/MxJHWt1thQKenwul 4QsOHHmopeLX+wTWVQ6K/6PbdX8CRvsbHxtQaz+V1+0FnBw+9DCD6iMqK4oND7GAES R5EEaU5Bp7sGVzBBqUcyxqnkrYqGj4Ad0+nhcdhgjsHruC/c/iMYuyn7Hc/Xc/ip6w EeQP8PqHIppsg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56057 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-i+bk06/ZF/Hb2ZEkFiWO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable A patch has already been written for rust-clap-derive-3: . That patch series also adds rust- clap-lex, so some inheritance may be in order. On rust-windows-... crates: these crates are unnecessary in Guix. If a package complains about not finding the dependencies, you can just remove the dependency declaration from the Cargo.toml Likewise, #56037 already updates rust-textwrap. Also, rust-adler is already in Guix, so you can use inheritance there. Why is there a separate rust-autocfg-1.1, instead of updating rust-autocfg@1.0 to rust-autocfg@1.1? In rust-object: why change the inheritance? In rust-once-cell-1: Why remove the skip-build? Also, you removed some dependencies (rust-crossbeam-utils, rust-lazy-static and rust-regex), but they are still used, according to . Also, if you're willing to wait a bit or help out, I've been working on simplifying the Rust packaging system in . (TBC: only some quick comments, didn't look in any detail) > + `(#:tests? #f ; missing files Then you can add the missing files. > + (synopsis > + "Tool to conveniently learn about the disk usage of > directories, fast!") > + (description > + "This package provides a tool to conveniently learn about the > disk usage of > +directories, fast!") Is markety, and the synopsis and description just contain the same information. See (guix)Synopses and Descriptions. Greetings, Maxime. --=-i+bk06/ZF/Hb2ZEkFiWO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq4y5hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sBsAQDAhQWdOuKDK8G8GkTuWHtDFaCj PnrL6bNov5r6OH33DgD/X5hTKsCYX0IplPlJrjEUI4nQ6cBt1SHjhSSn7HJM8w0= =zWCz -----END PGP SIGNATURE----- --=-i+bk06/ZF/Hb2ZEkFiWO--