From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 16:26:00 2022 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 20:26:00 +0000 Received: from localhost ([127.0.0.1]:40031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TOp-000639-PM for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:26:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TOo-000630-V8 for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOo-0002z0-6T for guix-patches@gnu.org; Thu, 23 Jun 2022 16:25:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOl-0004Ez-8k; Thu, 23 Jun 2022 16:25:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=vo/SvIrHUX3pf7NCy4JjuV4Kxf+Zdl/MHHbY3f+n5bw=; b=Sg9o5tq6aAUjK7Qh7pq8 J2CqZ3vSlnYOoE6mEkZT89EFxZ/00s/lsKX9lRKglyhBXXL3t5vQWsZ2fjOI0TKiCfty++CbQ69rz FsnDw2rQYayUHHQc4qpwRnb4b/gJZBcvomWX/raqHyGpHv0ZM9vH/33WyCwQajIPjrCSgmTyvRubF vNTcPFzNT2qMKvCFm/hfnaADiRMgJ3nw++K7MEQUfyRuiT/grl0N09PkXAfJNWCRgCRJ3rI2IBUpH SpgyrzrFx+eDh0MFo+RfNmjzFl8W2qXDE/tckW8YSD4pEI93Kr+XnOyjwlI150R+j4D+MMKPIm3O6 qoh1RnARHVFP4Q==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:33124 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOj-0001ON-Ov; Thu, 23 Jun 2022 16:25:55 -0400 From: Marius Bakke To: Nicolas Graves via Guix-patches via , 55961@debbugs.gnu.org Subject: Re: [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema. In-Reply-To: <20220614094954.15197-3-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-3-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 22:25:52 +0200 Message-ID: <878rpnrusv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-protocol-buffers-schema): New variable. > --- > gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index af3745f601..3f49955e29 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -233,6 +233,36 @@ (define-public node-oop > while being as light-weight and simple as possible.") > (license license:expat)))) >=20=20 > +(define-public node-protocol-buffers-schema > + (package > + (name "node-protocol-buffers-schema") > + (version "3.6.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/mafintosh/protocol-buffers-schema") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0lnckxj14jzsnfxdd5kmlwrac43c214bv8i2g5rdldymlpxzrz1v")))) > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--product= ion") > + #t))))) Same comments as before regarding arguments and indentation. > + (home-page "https://github.com/mafintosh/protocol-buffers-schema") > + (synopsis "No nonsense protocol buffers schema parser written in Jav= ascript") Avoid marketing words such as "no-nonsense". :-) Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTMUA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHdRmAD/SE0vNedfCx2smqbiRQ3uDI5zdMDqdEgiM2L8 vi7CHh0BAK4vQLaW3OtuJfc1XN1rloAWf2EcoZzqatVSRxbZbNkM =3tiN -----END PGP SIGNATURE----- --=-=-=--