From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 17:07:33 2022 Received: (at 55960) by debbugs.gnu.org; 23 Jun 2022 21:07:33 +0000 Received: from localhost ([127.0.0.1]:40092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4U33-00078H-6E for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:07:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4U30-00077p-14 for 55960@debbugs.gnu.org; Thu, 23 Jun 2022 17:07:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U2t-0001rY-G2; Thu, 23 Jun 2022 17:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ZSl7AxOT5s6zq56LDWw3yPXBv/Kn86dc2uqmHvtJkTs=; b=HM/zHO4Jq2GKSdklQL+9 xcjZ/fxIKg9TfiO0Tc2/NWYiLrQ7a8NA7EMLqjASva89ieYFd2c54FwVoPjzMelDoQudMZGgkVvAB iXznIX2zYOPPmTh4ImMVOdibLrv8j6LU9esoe+zM68Cj1Jc5tzsnlWJFPg6fK4ZQDJ0ecaOyXxOmx obNeQchSI/JiFw24efZsdC8zG8Z8bVXa2iKX8krLG1t9Ez269Zp+BGpkSQtSYCOY3O1b0Vrwg20ZP SGiYAjPoiaPpQKYABQlYpk2cJnS+H1iFb9j0TpIy1yEXcGbxfXbUtfcxgppHTnrA8No+zJOGig33r ZXfa1o1qcCMC5w==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:46178 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U2t-0005nX-0e; Thu, 23 Jun 2022 17:07:23 -0400 From: Marius Bakke To: Nicolas Graves via Guix-patches via , 55960@debbugs.gnu.org Subject: Re: [bug#55960] [PATCH 5/9] gnu: Add node-ieee754. In-Reply-To: <20220614094954.15197-5-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-5-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 23:07:20 +0200 Message-ID: <8735fvrsvr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55960 Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-ieee754): New variable. > --- > gnu/packages/node-xyz.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index 8f3288f219..3d945871cd 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -458,6 +458,37 @@ (define-public node-once > if desired.") > (license license:isc))) >=20=20 > +(define-public node-ieee754 > + (package > + (name "node-ieee754") > + (version "1.2.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/feross/ieee754") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "19rlg59lavnwsvbblhvrqwinz2wzqlxhddqpwrc3cyqkscjgza7i")))) > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--product= ion") > + #t))))) I realize all of these were copy-pasted so I won't repeat any more. ;-) > + (home-page "https://github.com/feross/ieee754") > + (synopsis "Read/write IEEE754 floating point numbers from/to a Buffe= r or > +array-like object") > + (description "This package allows to read/write IEEE754 floating poi= nt > +numbers from/to a Buffer or array-like object in Javascript.") Can you try to either shorten the synopsis or expand on the description to avoid duplication? Writing good descriptions is often the most difficult part of writing a package definition... The upstream documentation is not very helpful in this case. :-/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTWCA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeKsgEAkhtRtT5gT9TzanP2/UvVmhWbpA47d5uGpxGC AK9nPJkA/3uFXub/pSsI08vAUmjKA/EG7x2kAMssTjXJKmuo0mEC =XZvy -----END PGP SIGNATURE----- --=-=-=--