From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 16:15:49 2022 Received: (at 55958) by debbugs.gnu.org; 23 Jun 2022 20:15:50 +0000 Received: from localhost ([127.0.0.1]:39994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TEz-0005lK-Jv for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:15:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TEx-0005ku-Ub for 55958@debbugs.gnu.org; Thu, 23 Jun 2022 16:15:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TEr-0002ho-FU; Thu, 23 Jun 2022 16:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ruIxYJQelnPAPAFgr9cNff2CjuCw2cpY1EfGpIr/Axk=; b=pAYAnDXFMFi5pse8xA8q HEwiMkMxLNYjHNC81PiHZ5CI6BiE4D7uAL6+N4rMoJx2+KIZEvIo1cH9Qaa16dSuaKQPgfrPHmE9I B9m49ZjQRKGWxKyGszVwPknl8WhQroRMC2gKRTKjr64+F7Ifdv3y43NqABb4hRahvS3K0BTZm8AHG EvULTpTc4QKTus/XoEdr4IwyTCULoaUmtzIz8Kcl+dHWBNV1YM+W2MJ5X4/0IOmtYK+vuRqxA8XYO FjbCFhEAEBGajvdg+u/lJLbnXz67soKxHfls1I9I94FkjnmX+Nej6QiH/I0GuLNzB0wFsKrXTdJ1a WuM2TDqzwgUw4Q==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:57824 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TEr-0008TO-0I; Thu, 23 Jun 2022 16:15:41 -0400 From: Marius Bakke To: Nicolas Graves via Guix-patches via , 55958@debbugs.gnu.org Subject: Re: [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32. In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 22:15:39 +0200 Message-ID: <87edzfrv9w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55958 Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-buffer-crc32): New variable. [...] > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) Use #:tests? #f instead of deleting the phase. > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--production") Use (search-input-file inputs "/bin/npm") instead of (assoc-ref inputs ...). Although in this case I think you don't need the absolute file name as "npm" should already be on PATH, so you can just (invoke "npm" ...). > + #t))))) There is no need to end phases on #t any more. > + (home-page "https://github.com/brianloveswords/buffer-crc32") > + (synopsis "crc32 that works with binary data and fancy character sets, > +outputs buffer, signed or unsigned data and has tests.") Try to keep synopses short, and avoid duplicating the description. Maybe something like "CRC32 implementation in JavaScript"? > + (description "This package provides crc32 that works with binary data and s/crc32/a CRC32 algorithm/ > +fancy character sets, outputs buffer, signed or unsigned data and has tests, for I don't understand what "outputs buffer" means here, can you elaborate? Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTJ6w8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHearQD/UN+RzfTh3NNy1OYtJgrgVaY7IMFBNAPK1C4O nq/KM+sBAMwlTqz8YVIB8/wnymr7pVn+1snHGB+fccDjfAgnFwcF =WA9o -----END PGP SIGNATURE----- --=-=-=--