From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 12 08:33:26 2022 Received: (at 55903) by debbugs.gnu.org; 12 Jun 2022 12:33:26 +0000 Received: from localhost ([127.0.0.1]:55003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0MmT-0007At-Uv for submit@debbugs.gnu.org; Sun, 12 Jun 2022 08:33:26 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0MmS-0007Am-MT for 55903@debbugs.gnu.org; Sun, 12 Jun 2022 08:33:25 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0487D43CE9; Sun, 12 Jun 2022 14:33:24 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pNTkISh55f1d; Sun, 12 Jun 2022 14:33:23 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1655037203; bh=b5rTKa/dN7jjRmF4Sj3hK7AjYGCk3xux1KUYSMJzV3Y=; h=Date:To:Subject:From:References:In-Reply-To; b=Hr/7xI7dIjIgPvi7wF5ivpM4PuLlvwhw46r6xzXPekAdl0bVRgO+u00nGRsJSSPRo GIyV0CDhOPHb/revaIevBwbL/M2nYNnx6QROqGxnCBYwZLNaZZo15MmJl0zzc4WXZF yt9X48FtV+3H1AIZ2tSlAQ/M+Bd/hT1QeABZMk0E4uuh4iRVIAHS+atPza/dNcuUcU 8FUbNL9fk9Q6gB6VW/+Urr5x77P0TKTqflfLw4r50Ii5WbIkGYO9I8zN3h7qhpvOWy Os3kZut780lG4x1n//0MMWYSfJMWSi7uR7UxmwFtxTQlZCLTVLqipPJgstV40BOFeU 4JDHrfu8YNiaQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 12 Jun 2022 13:33:22 +0100 Message-Id: To: "Maxime Devos" , <55903@debbugs.gnu.org> Subject: Re: [bug#55903] [PATCH 02/41] gnu: Add go-github-com-creack-pty. From: "(" References: <20220611191653.15471-1-paren@disroot.org> <20220611191653.15471-2-paren@disroot.org> <62368a0ba241a2d35115051cd6aa82efdf102407.camel@telenet.be> In-Reply-To: <62368a0ba241a2d35115051cd6aa82efdf102407.camel@telenet.be> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55903 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat Jun 11, 2022 at 11:38 PM BST, Maxime Devos wrote: > In the previous patch series, =E2=80=98go-git-sr-ht-sircmpwn-pty=E2=80=99= was used Presumably sircmpwn-pty was a temporary fork done for one reason or another. The go.mod now uses creack-pty. > Likewise, why the change from sircmpwn/aerc to ~rjarry/aerc? Drew DeVault stopped maintaining aerc, so rjarry forked it -.o.- > Likewise, why has the 'wrap-program' been dropped in aerc? Not sure why that wrap-program was there in the first place. Maybe aerc invoked some ncurses program at one point? Strange thing to do. Anyway, the PATH change isn't required anymore, so the wrap-program isn't either. aerc *does* invoke colordiff for displaying some messages, but I'm pretty sure that invoked programs shouldn't=20 > Please mention such things in the cover letter. This patchset was actually done from scratch; I didn't include any of the original code, and I hadn't actually looked at it, since aerc has changed quite a lot.