From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 16:33:31 2022 Received: (at 55896) by debbugs.gnu.org; 7 Jul 2022 20:33:31 +0000 Received: from localhost ([127.0.0.1]:58101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9YBn-000248-FD for submit@debbugs.gnu.org; Thu, 07 Jul 2022 16:33:31 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:42577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9YBj-00023o-F5 for 55896@debbugs.gnu.org; Thu, 07 Jul 2022 16:33:29 -0400 Received: by mail-qt1-f179.google.com with SMTP id g14so24510371qto.9 for <55896@debbugs.gnu.org>; Thu, 07 Jul 2022 13:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=; b=nA2oLpE8B0VcHbHee7sEa/xZtgBNGDiEpAZtkdhw2kukKgPf3H6+lAYAV7ZKFYKY7o asBiSnM6Nqi1oIFTBijwG4gcSl4vN1G6/yHOLoPQRRwoZcqzfVOAyXwQFhJ4gGrX3oxU gcyNXj2SqffoeobiFStLNd5hZA7TZJwvUZgOn+IQvRakQG1xt67Saa6xegP5/SPEH4Xe 6JRG+WLgtSz8CRJ6vSVTC4MyUiqnuxiTdb3oGrIyyi1ubQKu8prSgi8ZzJ2M5N+/ft/V Ssz1/pwxKUnFmCghtW9ZGJJsIKh0FsbbrlEM+fMcM/64Sf6LTzSjbil3uZNJq8agbJDa TGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=; b=RMEFT7NQQ/z0owxqavYB5aqQiC+fyTwM/vhrQ+0HdPRv9VEn77XnvkdHNyDI83+Zj5 YgB9A9kMp33a4odrx+QaA4nShKfWhN540UohQYeTShzH0gMYxq8QHULiawOqeuzgvmsW BCprVdWHMcftU479m2Ypjz3wys020EYB9V4ZVytmCjl+G5IGvl3P7groSF0v08yOrUXU AVoyTM2B9JsFXNi8oUyAPxLRt9Mgf2lPXmssInywr2xAtIt+QMDxRlSv9z0qlpk1VVkr +NH5M+33LY37bs9ZUlLTOhBIuYzMeSUJE534mnN5ofCSp+7FRh8p6zy8eetbDOehfESf lxnQ== X-Gm-Message-State: AJIora8SfqrhVIxdHX4mI76xeK9h/mwqvrAIeMADGN08mniMmv6CxAvB Nzvg9p2Q492j5+JWBs2LY9cMTPycSGRkn0kq X-Google-Smtp-Source: AGRyM1vpTFrRNtos3vCJDugEmXCdaWCZoozXy4OtODkAqqRkx6rpPppZl34kF628Y76M390QrwuXXQ== X-Received: by 2002:a05:6214:29e9:b0:473:63b:5c61 with SMTP id jv9-20020a05621429e900b00473063b5c61mr12717082qvb.99.1657226001791; Thu, 07 Jul 2022 13:33:21 -0700 (PDT) Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127]) by smtp.gmail.com with ESMTPSA id dm15-20020a05620a1d4f00b006b555509398sm1668465qkb.136.2022.07.07.13.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 13:33:21 -0700 (PDT) From: Maxim Cournoyer To: jgart Subject: Re: bug#55896: [PATCH] gnu: Add python-pybare. References: <20220611202700.5655-1-jgart@dismail.de> <20220612155418.GC1648@gac> Date: Thu, 07 Jul 2022 16:33:20 -0400 In-Reply-To: <20220612155418.GC1648@gac> (jgart@dismail.de's message of "Sun, 12 Jun 2022 15:54:18 -0500") Message-ID: <87h73swtm7.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55896 Cc: 55896@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, jgart writes: [...] > Hi Maxime, no worries. Take your time. The review is much appreciated. > > I just looked at the sources again myself and noticed that the tests > use pre-generated BARE binaries to test against. > > See here: > > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225 > > and here: > > https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples > > Should I ask the author if they can provide a way to generate those > binaries for testing instead of vendoring the pre-compiled binaries > without their sources? Yes, please ask. Otherwise, we'll have to delete the binaries from unknown source in a source snippet and not run the test suite... Thank you! Maxim