From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 03 02:04:19 2022 Received: (at 55774) by debbugs.gnu.org; 3 Jun 2022 06:04:19 +0000 Received: from localhost ([127.0.0.1]:55008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx0Py-0001pb-W4 for submit@debbugs.gnu.org; Fri, 03 Jun 2022 02:04:19 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:43913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx0Pu-0001pI-8s for 55774@debbugs.gnu.org; Fri, 03 Jun 2022 02:04:17 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LDslb0YTYz3wZs; Fri, 3 Jun 2022 08:04:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1654236251; bh=w8x9cp7+WZf0EJwxXhaGKgRjVzhOqfe7ozG9baia1z0=; h=Subject:From:To:Date:In-Reply-To:References; b=neCcK0trjbFdRnmlOqgF2k7TMY4vZSJexk5TNaHe3pqTiuWhJXK39KYWfw4fSEgzi y+JOaMr+ARQYV+HUYMm+120MoNvYL1NWU0fk891pYarKfeO6eyYibyVLvLjRQtsMXU V2d29tluLSWsudMbmCRXxwUfuSgbD5oTGVQeUFJw= Message-ID: <5d389f5061f937d238b758b23c61c3621a519b9c.camel@ist.tugraz.at> Subject: Re: [PATCH] gnu: quodlibet: Add dependencies for plugins to work. From: Liliana Marie Prikler To: "Wamm K. D" , 55774@debbugs.gnu.org Date: Fri, 03 Jun 2022 08:04:10 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -0.4 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55774 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D: > * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to > work. Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS... > --- >  gnu/packages/music.scm | 13 ++++++++++++- >  1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index 554d70f266..3751305b3c 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -47,6 +47,7 @@ >  ;;; Copyright © 2022 Sughosha >  ;;; Copyright © 2022 Remco van 't Veer >  ;;; Copyright © 2022 Maxim Cournoyer > +;;; Copyright © 2022 Wamm K. D. >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -179,6 +180,7 @@ (define-module (gnu packages music) >    #:use-module (gnu packages vim)       ;for 'xxd' >    #:use-module (gnu packages web) >    #:use-module (gnu packages webkit) > +  #:use-module (gnu packages wm) >    #:use-module (gnu packages wxwidgets) >    #:use-module (gnu packages xdisorg) >    #:use-module (gnu packages xml) > @@ -6752,7 +6754,16 @@ (define-public quodlibet >             python-pygobject >             python-pytest >             python-sgmllib3k > -           python-toml)) > +           python-toml > +           ;; optional but needed for multimedia keys not under > Gnome > +           keybinder-3.0 > +           ;; optional but needed for Undo/Redo > +           ;; support for multiline text fields > +           gtksourceview > +           ;; optional but needed for the auto library update plugin > +           python-pyinotify > +           ;; optional but needed for the Musicbrainz plugin > +           python-musicbrainzngs)) YMMV, but it's better for inputs to be sorted alphabetically. Use line comments to demarcate specific features, e.g.  keybinder-3.0 ; keybindings outside of GNOME gtksourceview ; undo, redo, multiline text fields ... Don't forget the 79 character limit; when in doubt claim less features. If possible, try to line up the comments. Also, comments like "musicbrainz plugin needs python-musicbrainz" are not as informative as you'd think and can probably be dropped :) Cheers