From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 12:17:42 2022 Received: (at 55763) by debbugs.gnu.org; 4 Jun 2022 16:17:42 +0000 Received: from localhost ([127.0.0.1]:59548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT8-0003a9-9Z for submit@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:42 -0400 Received: from jpoiret.xyz ([206.189.101.64]:42998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT6-0003Zz-4Y for 55763@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:41 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3BF1A184F27; Sat, 4 Jun 2022 16:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1654359458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0jP0Ei3y/hVT5Uv+W/NcR9F/OpaV3knlfRyS206rnE=; b=kiSnPhhuRxcqWMzQ0uwywcvhvlxDUfHTX2b9ciVuIxaKwh1NpszQIbxhA6HnH/SAN74c5c sVvzOGMTxOSxIOAHCtRQEFN6l+SUssiUeWzgVMJiQ2h7Qui1afBhYG+JzKg4P9wrSlZUTU iRdeGYkitsXUxWrOfddMywnJtcdOCVMk4mlMM26Nukqx53DNh0IFkq78ww6IejKrYt9E7q HVSglDsVqeSCxDbaqeOrab70NcK7MTr4DUSxh1EuO3iAE1yR8dMI+YigRf6utD/D3tE70q qCNTKOp/bi8dgoEfR+fF/5o5VjCmHcwsMTFiyvqZYqfCpq51Cf1GY4x+LJs1qQ== From: Josselin Poiret To: Felix Lechner , 55763@debbugs.gnu.org Subject: Re: [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 In-Reply-To: References: Date: Sat, 04 Jun 2022 18:17:37 +0200 Message-ID: <87leucwggu.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the comp [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 55763 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the comp [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the compile-ffi script in nyacc. Unfortunately, the highest > version we ship suffers from a bug that prevents the script from > running on the pam_client.h header in linux-pam. This patch upgrades > nyacc to the version Matt Wette released after committing the fix. > > The changes are further documented in the commit message. > > I am new to Guix and already use the new version of linux-pam locally > (via Guix System) but I was unable to test the patch according to the > requirements and recommendations listed for this submission. [1] > > This email was sent to -devel in lieu of -mentors, which does not > exist. Any guidance is much appreciated. Thanks for taking a look! > > KInd regards > Felix Lechner > > [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html While the contents of the patch look good, you're missing the standard ChangeLog format for the commit message, see "(standards)Change Logs". I would recommend something along --8<---------------cut here---------------start------------->8--- [Your message] * gnu/packages/mes.scm (nyacc): Update to 1.07.0. --8<---------------cut here---------------end--------------->8--- Also, I think that inline patches are preferred, even though the manual says that MIME is fine too. The usual advice is to just use git-send-email to send patch series, which will take care of everything itself (you can check out a tutorial at [1]). You could send a v2 patch, or maybe a maintainer will add the necessary format themselves and commit, whichever comes first :). In any case, thanks for your contribution! [1] https://git-send-email.io/ Best, -- Josselin Poiret