From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 14:42:46 2022 Received: (at submit) by debbugs.gnu.org; 2 Jun 2022 18:42:46 +0000 Received: from localhost ([127.0.0.1]:54595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpmQ-0001dE-4b for submit@debbugs.gnu.org; Thu, 02 Jun 2022 14:42:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:38460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpmM-0001d5-Lc for submit@debbugs.gnu.org; Thu, 02 Jun 2022 14:42:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpmM-000343-By for guix-patches@gnu.org; Thu, 02 Jun 2022 14:42:42 -0400 Received: from tobias.gr ([80.241.217.52]:39158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpmK-0003Nb-8B for guix-patches@gnu.org; Thu, 02 Jun 2022 14:42:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=ib0nesmCH2eJn yscfmwqHN2Kqy3vs+Yd3D6mG4ITwwU=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=AbUZLvMFsPCZAe/l3jIVX9mPkdmfcahRnBBBbc pXwWZLkvhDFAGZlpTnzw6qtNCOIc3gAbAWOu2++Fif3g1f4l5EgokPC3d6QiFGy9iWfCWB jiER6B9ceipmJiKzbzR+PJ1458+si5Plo4ufqUiZ2jBvORxIj5GoU0gRTXiHZ6SrldioaJ XGzZF+y2Z4fbDnC4leMD9Jw3fEm5maCPteKbtt8tC6TkoBIrSpZ4JDe75n7vPWtfcMdpIW kC21KmHJsmAN2A2uPHBcMnmA0J7zelr/bt4GdSXaiyIdrIVq+sH52Ai1WZAHYZL5lCWyo+ Dc/XBU5kgDYBE2fnPp4OZqNg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e83b77a7 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 2 Jun 2022 18:42:34 +0000 (UTC) References: From: Tobias Geerinckx-Rice To: Felix Lechner Subject: Re: [bug#55762] [PATCH] Upgrade linux-pam to 1.5.2 Date: Thu, 02 Jun 2022 20:16:27 +0200 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkva9aat@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=80.241.217.52; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: 55762@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Felix, Felix Lechner =E5=86=99=E9=81=93=EF=BC=9A > For my work in making PAM configurable in Guile, I rely on the=20 > foreign > function interface (FFI). The automatic generation of that=20 > interface > requires Pkgconfig files. Those files are not available in Guix. > Linux-PAM started shipping them in the release after the one we=20 > have. > The attached patch upgrades linux-pam to version 1.5.2. Thanks for working on both! > The changes are further documented in the commit message. And thanks for writing a clear commit message. A few thoughts: =2D The =E2=80=98gnu: foo: Update to x.y.z=E2=80=99 messages you see in the= Guix=20 commit history are standardised. The format's documented in the=20 GNU =E2=80=98(standards)Change Logs=E2=80=99 info page, but just take a s= troll=20 through the history to get a feel for the majority of cases. =2D Don't feel obligated to explain why you're upgrading a package,=20 although you're free to do so if you like (it was interesting=20 and I learnt something). Assuming no regressions, we always prefer to ship newer versions=20 of things. =2D And finally, a personal windmill of mine: > The extra argument to ./configure is needed to sidestep an issue > upstream.[1] belongs in the code, where your fellow hackers can see it, not=20 buried in the commit log where $nobody will: ;; Work around=20 . As you might now, this update rebuilds a good part of the world=20 and will have to pass through the core-updates branch=E2=80=A6 $ guix refresh -l linux-pam | cut -d: -f1 > I am new to Guix and already use the new version of linux-pam=20 > locally > (via Guix System) but I was unable to test the patch according=20 > to the > requirements and recommendations listed for this submission. [1] =E2=80=A6so it's impressive if you rebuilt most of your entire system=20 based on the new nyacc/linux-pam packages. What still needs to be done, and which problems did you encounter? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYpkEmg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15MWEBAKcm0YoPpP+Z+vxkhUDdTgary0pBKegpyDbjJWaa GaEwAP9RmN3Qex12Wt30yslDS4//yDCmZJ2LAQw6igyYTu3ZAA== =Ga8Z -----END PGP SIGNATURE----- --=-=-=--