On 2022-08-11, Maxime Devos wrote: > On 31-07-2022 01:41, Vagrant Cascadian wrote: >> + (replace 'check >> + (lambda _ >> + (invoke "make" "test")))))) > > I expect "./pre-inst-env guix lint lcrq" to have a warning about > respecting #:tests?. This is important for --without-tests and > cross-compilation. Likewise for the other patches. Oops. Looks like Efraim caught this after I pushed, at least. >> + #:make-flags (let ((target ,(%current-target-system))) >> + (list ,(string-append "CC=" >> + (cc-for-target)) >> + (string-append "PREFIX=" >> + (assoc-ref %outputs "out")))) > 'target' is unused and can be removed. Nice catch, will look at it! live well, vagrant