From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:46:27 2022 Received: (at 55005) by debbugs.gnu.org; 18 Apr 2022 18:46:27 +0000 Received: from localhost ([127.0.0.1]:40767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWOI-0007DK-Oh for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:46:26 -0400 Received: from gamma.thomaslabs.org ([38.242.253.186]:53670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngWOG-0007D8-Ry for 55005@debbugs.gnu.org; Mon, 18 Apr 2022 14:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; t=1650307582; bh=UphawHIDVAYMjWROEUQ0MfTssYcoID9Vk2HEAauLKDY=; h=in-reply-to:date: subject:cc:to:from:references; d=thomaslabs.org; b=ATLSf3ozSADvQ2liHvr Bg5xT0ILvlRsDAux7AGQ3nRnbOWX3O5LL/B2jq9WeDTMOJ5ppXiLkspKt5DHGJdCg+UOjr BQI0vzL99Jd4RkMrQsMb8leFa0PJAp7jBdgz7sNjZSZ1QqRIpI+EUK4/tgLRFs4K1vOsMV H93MeFN+3RKfxiVPDfi+iVuULTmUtznuVWcixWm0dihaKbZvgsxpTklGuefOT/sOdqW9Oh mUJEzd8LXnrVQATDR+iiNO1TEzyBDpOb/AfzBnPcLIeFVMnj4j/CmAVBnuazGisLpek9z/ 7YUvn7JKNWZQtLPQBypTi5iTUequ5fYUICHCLp7ORvg== Received: from alpha (ip1f13c149.dynamic.kabel-deutschland.de [31.19.193.73]) by gamma.thomaslabs.org (OpenSMTPD) with ESMTPSA id 0dc4bfd8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 18 Apr 2022 18:46:22 +0000 (UTC) References: <20220418180957.19545-1-thomas@thomaslabs.org> <20220418180957.19545-4-thomas@thomaslabs.org> <7342b568f5f436782e8617f9e6f2450dc7b7d065.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Thomas Albers Raviola To: Maxime Devos Subject: Re: [bug#55005] [PATCH 04/13] gnu: Add ghc-githash Date: Mon, 18 Apr 2022 20:35:11 +0200 In-reply-to: <7342b568f5f436782e8617f9e6f2450dc7b7d065.camel@telenet.be> Message-ID: <877d7mxm9u.fsf@thomaslabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55005 Cc: 55005@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Thomas Albers via Guix-patches via schreef op ma 18-04-2022 om 20:09 > [+0200]: >> --- >> =C2=A0gnu/packages/haskell-xyz.scm | 25 +++++++++++++++++++++++++ >> =C2=A01 file changed, 25 insertions(+) > > A commit message is mising. > You're right. Not only for that package, but for all in the series. I was convinced 'git send-email' would add them automatically like it usually does. Is there a command line option for this that I am missing? >> diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm >> index 18baf7b2f8..314209f573 100644 >> --- a/gnu/packages/haskell-xyz.scm >> +++ b/gnu/packages/haskell-xyz.scm >> @@ -16179,3 +16179,28 @@ (define-public ghc-sqlite-simple >> =C2=A0=C2=A0=C2=A0=C2=A0 (description >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Mid-level SQLite client library, based o= n postgresql-simple.") >> =C2=A0=C2=A0=C2=A0=C2=A0 (license license:bsd-3))) >> + >> +(define-public ghc-githash >> +=C2=A0 (package >> +=C2=A0=C2=A0=C2=A0 (name "ghc-githash") >> +=C2=A0=C2=A0=C2=A0 (version "0.1.6.2") >> +=C2=A0=C2=A0=C2=A0 (source >> +=C2=A0=C2=A0=C2=A0=C2=A0 (origin >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (string-append >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 "https://hackage.haskell.org/package/githash/githash-" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 version >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ".tar.gz")) > > I would Put 'version' and ".tar.gz" on one line here. > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1vkwc7j71vdrxy01vlm= 6xfp16kam7m9bnj9y3h217fzhq5mjywhz")))) >> +=C2=A0=C2=A0=C2=A0 (build-system haskell-build-system) >> +=C2=A0=C2=A0=C2=A0 (outputs '("out" "static")) > > What are the static libraries for? > I am myself no sure. They are generated in the build process, so I thought to add them. >> +=C2=A0=C2=A0=C2=A0 (arguments `(#:tests? #f)) > > Why are they disabled? > Tests attempt to write to the read-only file-system. I'll add a comment explaining this. Is there a way to correct patches without having to send all over again? Is it possible to fix the mistakes by adding more patches to the series on top of the existing ones? Greetings, Thomas