From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 11:55:48 2022 Received: (at 54986) by debbugs.gnu.org; 13 May 2022 15:55:48 +0000 Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXdr-0006Cf-UF for submit@debbugs.gnu.org; Fri, 13 May 2022 11:55:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXdq-0006CT-BP for 54986@debbugs.gnu.org; Fri, 13 May 2022 11:55:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXdk-0001wp-VN; Fri, 13 May 2022 11:55:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zDg3DNOL2/Oqb3v9adKZ9vvJarDK4G6mm2nNGfSsIb8=; b=sICyZDk9VCYW0Rfu0+sc K6MeikNUQWqtmbA8Wc4Md60fjESLgqiXaaQoj+8vzbdm9ZXlg4AJa7gp/PPqF1tdhsZVj+e3zAZtd T7xS78veaP42PudQHqCrwvpyUa4ViycHXy14AlqW40r468QCh8dIxhPBUDrxhpl+wL1zjb7f4Egvg SC0lwgz0/0H/cAQvO2ijxHtE0Z7FDxBndLOZkon8HDn1cHnEQBhMjH0vE2ZHd4FaUrSuDzhab2VTh JwBpenSY/sVAZuJiv1Rfc2BQlMOHOuHH0vkb+9aZTf5WI1TrXagpY96+H7umnADxwZgitSDMvqjCl cdy6yWFSc7JWIA==; Received: from [193.50.110.244] (port=52724 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXdi-0000eP-BH; Fri, 13 May 2022 11:55:40 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation. References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> <87y1zqfabs.fsf@gnu.org> Date: Fri, 13 May 2022 17:55:36 +0200 In-Reply-To: <87y1zqfabs.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 28 Apr 2022 00:08:55 +0200") Message-ID: <87ee0xfmvb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Liliana, What=E2=80=99s the status of this patch series? Would be nice to have it i= n! Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Liliana Marie Prikler skribis: > >> * gnu/services/audio.scm ()[shepherd-endpoints]: New = field. >> (mpd-shepherd-service): Use it. >> * doc/guix.texi (Music Player Daemon): Document it. > > [...] > >> +++ b/gnu/services/audio.scm >> @@ -78,6 +78,8 @@ (define-record-type* >> (default "6600")) >> (address mpd-configuration-address >> (default "any")) >> + (shepherd-endpoints mpd-configuration-shepherd-endpoints >> + (default '())) ; list of > > The way I see it, service configuration should be oblivious to whether > it=E2=80=99s started as =E2=80=9Cforkexec=E2=80=9D, systemd, or inetd. > > There=E2=80=99s already an =E2=80=98address=E2=80=99 field above, so my s= uggestion would be to > reuse it. This is what I did for example for the openssh service, and > also for bitlbee and dicod here: > > https://issues.guix.gnu.org/54997#5 > > WDYT? > > Thanks, > Ludo=E2=80=99.