From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 18:09:04 2022 Received: (at 54986) by debbugs.gnu.org; 27 Apr 2022 22:09:04 +0000 Received: from localhost ([127.0.0.1]:44695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpqK-0006oA-C8 for submit@debbugs.gnu.org; Wed, 27 Apr 2022 18:09:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpqJ-0006ni-AD for 54986@debbugs.gnu.org; Wed, 27 Apr 2022 18:09:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njpqD-0000B1-88; Wed, 27 Apr 2022 18:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xw9jaGc4HDhftwm6DNQkQ7997JIT3DN8fEhbiQ1nyRA=; b=RTxQMuZvIiuryEx6zlyR lnKE0GkA+tw4jDDWRH4mgff5MdMlBj9OzfBUnO1ljDtKCC/F9pwUt2dzj+bZo//OJQInGp3OMzO3Z V+Ps5n7xFd7FFuSe+4d2lBXdaRtms1pS3658+5rO+Y/6jiGWIdSFjG0ZYTjD5nN6cVbZV50rznrao ppVBL0NKNOEH8ftiLUg7LM68o9IEzh24zX//OlzRdCMfUVJ3XzCxWponQtShbU2xhIE1R1l8bnYfV NynhL3hJPQ02vmtW+WmBcGIINLFamB8AJGBrW0yF5CWf5aUqZ8W6FK04RWYOl44fxf89FlrSiX4CZ Ci84PWlJx+xO2Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50558 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njpqC-0006nu-Qa; Wed, 27 Apr 2022 18:08:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: Re: [PATCH v2 3/3 WIP] services: mpd: Support socket activation. References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 00:08:55 +0200 In-Reply-To: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Apr 2022 16:39:59 +0200") Message-ID: <87y1zqfabs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Liliana Marie Prikler skribis: > * gnu/services/audio.scm ()[shepherd-endpoints]: New f= ield. > (mpd-shepherd-service): Use it. > * doc/guix.texi (Music Player Daemon): Document it. [...] > +++ b/gnu/services/audio.scm > @@ -78,6 +78,8 @@ (define-record-type* > (default "6600")) > (address mpd-configuration-address > (default "any")) > + (shepherd-endpoints mpd-configuration-shepherd-endpoints > + (default '())) ; list of The way I see it, service configuration should be oblivious to whether it=E2=80=99s started as =E2=80=9Cforkexec=E2=80=9D, systemd, or inetd. There=E2=80=99s already an =E2=80=98address=E2=80=99 field above, so my sug= gestion would be to reuse it. This is what I did for example for the openssh service, and also for bitlbee and dicod here: https://issues.guix.gnu.org/54997#5 WDYT? Thanks, Ludo=E2=80=99.