From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 12 09:25:16 2022 Received: (at 54852) by debbugs.gnu.org; 12 Apr 2022 13:25:16 +0000 Received: from localhost ([127.0.0.1]:48021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neGWB-00012J-Md for submit@debbugs.gnu.org; Tue, 12 Apr 2022 09:25:16 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:39541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neGW9-000120-1o for 54852@debbugs.gnu.org; Tue, 12 Apr 2022 09:25:14 -0400 Received: by mail-ej1-f46.google.com with SMTP id bv19so14314473ejb.6 for <54852@debbugs.gnu.org>; Tue, 12 Apr 2022 06:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2YaMG7IZJLdgoFMRs8QyVxQLPq93WJI0PbSebXzcfU0=; b=Vrn9fQSGwd9U5eqqKkfP5GP1SyWMIv1AiMCsMwweD34ZZpaHDX1yWz/w+oknc914fx q0k4vWJBae1jLu6qFmQ8JlnsdRnP2vlTEUVx/Sns6hH93na23dFseMwmWeU78Vj8GpVQ S3V4Pf14irYDiJ1pyg4HLicIEjRusgTBQWJxJD94/7S/q13y8tiBeqwRS424tpUBzWNx 9PXWCexk3A4SVj28fOp8KbXqP/YB+EzTwcKIG07Jma5qA3Zf0curILpYWCzFjEZC9vtU ECBZK/SnKmkx0sReVTT/L1vJSGBJj5mx9RX1cCpO5/p5InSKkpHylfTAkVbQ4a7he5y/ LODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2YaMG7IZJLdgoFMRs8QyVxQLPq93WJI0PbSebXzcfU0=; b=TH4MZzXqsYsia2aASc+disvvP0sBcGL2yUV5Ecfc6xdxBPygDKaKmwnnyZYHw333Wk HpQhghVKaYVZ+YUw+m+WMhWfJJUkUbeivmCteQ04MWfj1vhTCeVEvTCV1RJz+dYFHYHm ENWQnH0DycMYOWwy7htmmJEJ55G943AMJocnk//JNXq3alsTtU8KkTD7lmi1KNmWHxhu bWEM9W0rUIxbFSzgQB5xGFdDMCXNWtNrDIXDPQhFGqA8i9ldayX691+vg9s3ud1K+W67 3GSU1SR0ZGdH4vDch5nEyUKIFpMF2x9BnTA/grkvWsSWOzkfDoHMMh6C1BdovEepF7YY V67A== X-Gm-Message-State: AOAM531PTKw98+qvec020IpJFS220SjQ59wQOOr+SEwe4l6OZocT9U5x S0U1jhWlAGjGizzRgzdSdHBuDa6bfeI/YVYmwPc= X-Google-Smtp-Source: ABdhPJx3KUgo3YLLjlQaLFkGsgN4A+kZfQBXulBVMW+u/uwUkrpxhaw5t48iPRKFwZISE1nJLMWaMLaHwckp0FmiWao= X-Received: by 2002:a17:907:6297:b0:6da:6388:dc58 with SMTP id nd23-20020a170907629700b006da6388dc58mr35387391ejc.472.1649769906983; Tue, 12 Apr 2022 06:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> In-Reply-To: From: Rostislav Svoboda Date: Tue, 12 Apr 2022 15:24:30 +0200 Message-ID: Subject: Re: [bug#54852] [PATCH] gnu: Add openjdk18. To: Maxime Devos , Julien Lepiller Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54852 Cc: 54852@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le lun. 11 avr. 2022 =C3=A0 15:44, Maxime Devos a = =C3=A9crit : > > + (arguments > > + (substitute-keyword-arguments (package-arguments openjdk16) > > + ((#:phases phases) > > + `(modify-phases ,phases > > + (replace 'fix-java-shebangs > > + (lambda _ > > + ;; This file was "fixed" by patch-source-shebangs, but = it requires > > + ;; this exact first line. > > + (substitute* "make/data/blockedcertsconverter/blocked.c= erts.pem" > > + (("^#!.*") "#! java BlockedCertsConverter SHA-256\n")= ))))))) > > Why is this duplicated? It is exactly the same phase as for openjdk17, > so inherit should take care of it. Le lun. 11 avr. 2022 =C3=A0 16:16, Julien Lepiller a = =C3=A9crit : > The patch looks great, but I wonder why you need to change che phases to = tomething that looks like openjdk 17's phases? Am I missing something? Woul= dn't it work without any change to the arguments? You're both right. We don't need that. (Sorry) I'm sending correction below= . Cheers Bost From 543aa7797308ea66d1d1140e72a48908a2e73419 Mon Sep 17 00:00:00 2001 From: Rostislav Svoboda Date: Mon, 11 Apr 2022 11:55:55 +0200 Subject: [PATCH] gnu: Add openjdk18. --- gnu/packages/java.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 6738b5dc35..ec0b956388 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2263,6 +2263,29 @@ (define-public openjdk17 (("^#!.*") "#! java BlockedCertsConverter SHA-256\n")))))= ))) (home-page "https://openjdk.java.net/projects/jdk/17"))) +(define-public openjdk18 + (package + (inherit openjdk17) + (name "openjdk") + (version "18") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/openjdk/jdk18u") + (commit (string-append "jdk-" version "-ga")))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8")))) + (native-inputs + `(("autoconf" ,autoconf) + ("openjdk17:jdk" ,openjdk17 "jdk") + ("pkg-config" ,pkg-config) + ("unzip" ,unzip) + ("which" ,which) + ("zip" ,zip))) + (home-page "https://openjdk.java.net/projects/jdk/18"))) + (define-public icedtea icedtea-8) --=20 2.35.1