From debbugs-submit-bounces@debbugs.gnu.org Wed May 11 14:13:18 2022 Received: (at 54852) by debbugs.gnu.org; 11 May 2022 18:13:18 +0000 Received: from localhost ([127.0.0.1]:38404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noqpq-0003N3-3x for submit@debbugs.gnu.org; Wed, 11 May 2022 14:13:18 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:43530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noqpn-0003Mr-C0 for 54852@debbugs.gnu.org; Wed, 11 May 2022 14:13:16 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id VWDD2700F4UW6Th06WDDRb; Wed, 11 May 2022 20:13:13 +0200 Message-ID: <8f19c4e7977c5171d68dfdea9e5991713973ca0b.camel@telenet.be> Subject: Re: [bug#54852] [PATCH] gnu: Add openjdk18. From: Maxime Devos To: Rostislav Svoboda Date: Wed, 11 May 2022 20:13:09 +0200 In-Reply-To: References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0gIcf1QwzMtf8IPqzvYG" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652292793; bh=AcA/WCF13Zhrg5ZAZE4UN5OL6cGvbzUYXmIS3G7iWNU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=QT6zOjdj4J47X63PQ+U97BbCrfEJ58T4Fb/iD4nLixqVHe7lk+SsWJ0j91U+NNloo gxz1Y40m6boJLpA2AiBAmZBFDYc8vzHkOGxC7Mwe96dppJ/4FWsrIYbqTgmtbWkclB I2KTgF8ek/SYKyXL5k9eQ+mhSgpIZrouOhz+yXCbpOTYWY61BCbgSD/DLcBMWRxQSI t9ieTtkN/0vVAQCHgym0Ybyp5/QxW+eu7IM5PJLmaGo4roitnEMGXr59QLd3QwCPvx JLBSVjzVwvYKmEbdluXpFNaU6YzT6iSjyMzIq8RhDn/NWpyMW7x+t4l0FwlPqOhK4c 1hYxiQHsw2dVQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54852 Cc: 54852@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-0gIcf1QwzMtf8IPqzvYG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Rostislav Svoboda schreef op wo 11-05-2022 om 17:37 [+0200]: > > > About the labels issue: maybe "icedtea-8" could be changed to > > > "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to > > > "openjdk:jdk" at some point in the future, such that the package > > > name > > > matches the input label and the input alist can be changed to a > > > package list. > >=20 > > is addressed, WDYT of (replace "openjdk" openjdk)? >=20 > ??? > Could you explain that please? > Because to me, out of any context, (e.g. when grep-ing over the > source > code,) that looks like a "replace a-thing with a-thing". I.e. > effectively, a do-nothing command. Oops, I meant (replace "openjdk" openjdkN). Basically, whenever we now have (native-inputs `(("openjdkN" ,openjdkN) ("openjdkN" ,openjdkN "jdk") [... other inputs ...])), let's replace it by ;; In the openjdkN+1 package (native-inputs (list `(("openjdk" ,openjdkN) ("openjdk:jdk" ,openjdkN "jdk") [...]))) such that we always use the same input labels for the openjdk packages (here, N is 9, 10, 11, 12, 13, 14, 15 or 16). Then the the native-inputs can be simplified to (using "guix style"): (native-inputs (list openjdkN `(,openjdkN "jdk") [...])) and further to (native-inputs (modify-inputs (package-native-inputs openjdkN) (replace "openjdk" openjdkN))) which means: take the 'native-inputs' of the previous version of 'openjdk', but replace the openjdk it uses (openjdkN-1) by itself (openjdkN). --=-0gIcf1QwzMtf8IPqzvYG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnv8tRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lYiAQCXwoLnno35pCBWSrGGm8Aflf22 dLjNycauHd7i19/C7gD/Y8Smhw/m62AITih6nVPAs1tP0SUkKcEuAm8i09Bb5Qc= =KVv3 -----END PGP SIGNATURE----- --=-0gIcf1QwzMtf8IPqzvYG--