From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 16:53:36 2022 Received: (at 54836) by debbugs.gnu.org; 27 Apr 2022 20:53:36 +0000 Received: from localhost ([127.0.0.1]:44542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njofH-0004eI-UV for submit@debbugs.gnu.org; Wed, 27 Apr 2022 16:53:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njofG-0004e2-Ti for 54836@debbugs.gnu.org; Wed, 27 Apr 2022 16:53:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njofB-0006Yj-Bw; Wed, 27 Apr 2022 16:53:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=eMkkihghH6gEqGUG16RKbUl6oln8nU9w9OKvJhSWHbw=; b=Sml2nnXU+podjtIHitTH FNfwN0VA8oRzxlbvuv38Q1iLEIK8/IiRhcGvtx26MSLSU60zgQlfzaNYpfZfehfIS4zni7sm11osB cHRUV9n6mvMPNDQBwPofnljcZerSGhegR9varP3zOC0UNoeuxBvEbHSM/IsPRC6M8hHQ5dwThTUMf ppGzkdWjcuVFcmIiW3ZfxFyrYGZ+bbESsGxi7+LXVvgCjdbdkCdqPFlBkccNA3egfemElk8rmtbzp iCkJWFA3OIhzUDDGVZ4fO1wVSuEfXL3Ozitn7fOUXbAEfSfg6K5vEHVreQzqZwYkX8IGnXjicHBbz ZibOZMljOGIy4Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55179 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njofA-0004QD-Vw; Wed, 27 Apr 2022 16:53:29 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Attila Lendvai Subject: Re: bug#54836: [PATCH 1/2] http-client: Fix redirection. References: <20220410133431.30058-1-attila@lendvai.name> <20220410134114.371-1-attila@lendvai.name> <87v8vfiya2.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 27 Apr 2022 22:53:26 +0200 In-Reply-To: (Attila Lendvai's message of "Tue, 12 Apr 2022 07:28:33 +0000") Message-ID: <8735hyjlix.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54836 Cc: 54836@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, And sorry for the delay. Attila Lendvai skribis: >> > It's not enough to just handle the thrown exception, because we need t= o be >> > able to get hold of the fetched content, too. >> >> Would it make sense, then, to use the lower-level =E2=80=98http-get=E2= =80=99 from (web >> client)? That would let the code deal with all the HTTP idiosyncrasies. > > > i think it boils down to this trade-off: > > 1) keep http-fetch simpler, at the expense of reimplementing parts of > it in the go importer (e.g. the redirection logic) > > 2) add this extra complexity to http-fetch, and avoid the extra > complexity of a local, potentially half-assed %http-fetch in the go > importer. > > 3) something else i'm not aware of For now, I=E2=80=99m somewhat in favor of #1. My take would be: try to implement whatever=E2=80=99s needed specifically f= or the Go importer; from there, we can eventually revisit that situation and maybe switch to something that=E2=80=99s more like #2. How does that sound? Thanks, Ludo=E2=80=99.