From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 29 05:45:53 2022 Received: (at 54525) by debbugs.gnu.org; 29 Mar 2022 09:45:53 +0000 Received: from localhost ([127.0.0.1]:59867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZ8QD-0002PS-6W for submit@debbugs.gnu.org; Tue, 29 Mar 2022 05:45:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZ8QA-0002HE-O2 for 54525@debbugs.gnu.org; Tue, 29 Mar 2022 05:45:51 -0400 Received: from [2001:470:142:3::e] (port=60826 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZ8Q5-0001QP-BJ; Tue, 29 Mar 2022 05:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EI79mHhqXt2aV9vu7zA5UkCW8smuyvdFNbAAPw4BIhI=; b=bw0Ud2ST7M/LnC9u5Szp EVNCr2haZlG737HkJn8IB+M8KafnSYCK7rkru050rjnGzx7cc7bwwNrJPNCuEmZ1BtKvYO5mpWtYA ZKEjxQvgReMga2/VW/RG9tHXSfK9vr3e+H0uT785GQGvZ7vwXgxWm+b0ktiV9fc4CJcCpEH5g4VqL WLUKxsUXs8XkrLkEpUDXOOCooOpeqJS2aizx8Y+X9LbbcJ7V+Uig7JJKuGlri55+KwX48rplHDKt6 fu2uiC2YRUuxGv4nGyuUBE6/D1xqANvgYjcZ48T/BHEGJB8QP8q5Cqsiw9Dz14NlGjvTMPFvPiqVQ YDKRgLp3khMMNg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38674 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZ8Pl-0002IX-63; Tue, 29 Mar 2022 05:45:43 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: tumashu@163.com Subject: Re: bug#54525: [patchs] Let thunar support plugin search patchs and add some thunar plugins. References: <20220322204942.9624-1-tumashu@163.com> <20220322204942.9624-5-tumashu@163.com> Date: Tue, 29 Mar 2022 11:45:20 +0200 In-Reply-To: <20220322204942.9624-5-tumashu@163.com> (tumashu@163.com's message of "Wed, 23 Mar 2022 04:49:42 +0800") Message-ID: <87o81p2itr.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54525 Cc: 54525@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, tumashu@163.com skribis: > From: Feng Shu > > * gnu/packages/xfce.scm (thunar)[native-search-paths]: new field. > [source]: Add thunar-search-paths.patch. Please add the patch to gnu/local.mk. > +++ b/gnu/packages/patches/thunar-search-paths.patch > @@ -0,0 +1,211 @@ > +From 848f1dfb2d2f404efa5371817285236d33b32a5c Mon Sep 17 00:00:00 2001 > +From: tumashu > +Date: Tue, 22 Mar 2022 20:16:19 +0000 > +Subject: [PATCH] Look for thunar plugins at $THUNARX_DIRS (Issue #748) > + > +THUNARX_DIRS is a list of directories where thunar plugins are looked > +for. It is needed for distributions like NixOS/GuixOS that do not > +install all plugins in the same directory. In NixOS/GuixOS each > +package is installed in a self contained directory. > + > +MR !197 There is no such thing as =E2=80=9CGuixOS=E2=80=9D, it=E2=80=99s called =E2= =80=9CGuix System=E2=80=9D. :-) Is this going to be included upstream? If yes, could you add the URL of the upstream discussion or merge request? (If it=E2=80=99s not included upstream, I would suggest =E2=80=9CTHUNARX_PL= UGIN_PATH=E2=80=9D or =E2=80=9CTHUNARX_PLUGIN_DIRECTORIES=E2=80=9D for the environment variable n= ame.) Apart from that, this patch and the previous ones LGTM. Could you send a v2 based on that? Thanks, Ludo=E2=80=99.