From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 14 19:06:55 2022 Received: (at 54379) by debbugs.gnu.org; 14 Mar 2022 23:06:55 +0000 Received: from localhost ([127.0.0.1]:46943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTtmB-0005Mv-Ed for submit@debbugs.gnu.org; Mon, 14 Mar 2022 19:06:55 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:43909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTtm9-0005Mg-6C for 54379@debbugs.gnu.org; Mon, 14 Mar 2022 19:06:53 -0400 Received: by mail-lf1-f49.google.com with SMTP id s25so29894171lfs.10 for <54379@debbugs.gnu.org>; Mon, 14 Mar 2022 16:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=79mWUIeqtSdKG+7+jwDKxKVv8AKo/gorEkq3BOgIRjs=; b=IwbHAoIdxmz7gLl+MHFyeBKhgWPWrzBKcMlk445BbIUzRtsPZrTArSsA+lc6+b26vQ vx61oR2vkLIFWJUtghzmjmgHQ7QpRiBqgfMw17sCFTMv+CFoiKiPA+/JNrVfPw6vEObc EICwBQuu/MNgjz6Fq7WRr6P/eXgWmDH2rGrfxTSTo7ZqQPgadEH0qylmY9pvJuJPH62I KbnU+tbMXAMBfIbUTnLwu7IE+WuXAqYu8R43xBsHMjqekbs/P7ibzlXlxO9kGChUCAxd fyefQpyTHVsOj+yWKwShtF0S5PnVlQE5PJ+pMCOSB6OF8C8e/ri5842le8oaL54RSd8V T5pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=79mWUIeqtSdKG+7+jwDKxKVv8AKo/gorEkq3BOgIRjs=; b=n8X5Zd5VVgf4TvFy3n8HCoNp6Agxd2qDHu6ENa8WcezqNaI5rbh2O5i+3WEFmS3/46 OzPIJqWv3xRXFPGCL7+ySj7ux25ZtlrhijMhV5hzzspBFtrZjpg2ARk7dSrCRUsRo9nZ se/I6tnEV/mdE2vv5Z31OZv1e9YHNy693lGgDlHHGoaUveUzkwlB4heE1Lw8j5v3HN4n 8mwuLmQxWSeLZ6KiaIq9tp4HY9UKO5VLgJ2113YV572f5+UlyhS2YiUzTnsHtbUAnQd+ ZORpeBDFc2f5rAZrj6oVBtzYujsNF9fig1rQJKGIa18FJwk/L5JOmNFzyt1SioHga8Yj W0ig== X-Gm-Message-State: AOAM531TibJH4Z7mheqvBE5dfIPobELKD9mDOQMGVlhQh08aJpOBiNYp 3Dc3cT6+CXtCbvXIHiV9rD3OM4KQH8ysWptK33BxCGbPr2s= X-Google-Smtp-Source: ABdhPJwTldwFEAlpui+Wt1BPRFDjGLoW0uxMf/50bFJbSsRTCDSVga452XN0UPdgGjGKkiCPffrDHKGr5NEnYqKuHy4= X-Received: by 2002:ac2:4241:0:b0:448:4b83:8372 with SMTP id m1-20020ac24241000000b004484b838372mr14505622lfl.463.1647299207032; Mon, 14 Mar 2022 16:06:47 -0700 (PDT) MIME-Version: 1.0 References: <1926705393.215334.1647246338511@office.mailbox.org> In-Reply-To: <1926705393.215334.1647246338511@office.mailbox.org> From: Kevin Boulain Date: Tue, 15 Mar 2022 00:06:10 +0100 Message-ID: Subject: Re: [bug#54379] [PATCH] gnu: linux: update PipeWire & WirePlumber To: Brendan Tildesley Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54379 Cc: "54379@debbugs.gnu.org" <54379@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 14 Mar 2022 at 09:25, Brendan Tildesley wrote: > > If you are updating pipewire, I'd like to add to it: > > 1. The attached libfreeatpx patch, or perhaps an improved patch. maybe one could expand on the description. It's very similar to what I've done locally. I decided to not include libfreeaptx in the first patch, even though I confirm it worked for me and I was able to use the aptX codec, because other distributions like Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1908922) or OpenSUSE (https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/message/E4POCRFIANNJPIXT4QYI245O3RSPVBW3/) have decided not too. Interestingly Debian includes it in its main repository (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995607). I'm not sure of the legality of all that, even if the patents appear to have expired, I'm sure someone must know better than me (is there a contact point in Guix or GNU?). > 2. Add the following dependencies to inputs: > libfdk for ACC support over bluetooth The AAC codec is already supported and included in the patch I submitted (libfdk was added to the inputs), the build system picked it up (but I can't test the codec). > libfreeaptx for aptX support over bluetooth See above. > libsndfile Already done in the patch, I confirm I could pw-record and pw-play (symlinks to pw-cat). > libusb for bluetooth support > lilv for lv2 plugins > webrtc-audio-processing for noise cancelling > readline for pw-cli Good point, I'll send an updated patch (I can't test them all but they were recognised during the configure). > 3. Consider renaming pipewire-0.3 to pipewire and pipewire to pipewire-0.2 to keep pipewire as the latest. > pipewire 0.2 is only needed by weston 9. weston 10 can use 0.3, but i was getting compilation errors. It was also bothering me a bit. Don't mind if I do :)