From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 18:16:12 2022 Received: (at 54284) by debbugs.gnu.org; 18 Mar 2022 22:16:13 +0000 Received: from localhost ([127.0.0.1]:58586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVKtI-0006Oo-Fv for submit@debbugs.gnu.org; Fri, 18 Mar 2022 18:16:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVKtG-0006JS-UW for 54284@debbugs.gnu.org; Fri, 18 Mar 2022 18:16:11 -0400 Received: from [2001:470:142:3::e] (port=36888 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVKtB-0003vW-8X; Fri, 18 Mar 2022 18:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=8xRYPpIcvPqJm5px/N8+adC4Y2x3ZjTryJzDPzpNpBo=; b=UK96yMwY8sIHGr37elh3 fX4Rb7EGQzdRPpn0oedzvQ8kE8V0X4GAK4JxpCk4DeuHToBZ7YeOjNeoUvb+yzHMZA3XuiPmFgXI5 HUG8SNMrl+SroOg8Cz0GOq/p3uU+JsB9aQIn+KvNoKv9ta3SCBFUlBqolck7PCWMA9RZchoKBWUug JQGYG2r5s5LqjdN+LEbHtWuKrpoIhw8pcF72EhjZPfcKNKxwBsyg6unErWRlAlxtfXzRojyJA/s7h WxCBtj+94cZHaInxJpuGbnMacerEk7YlvMAujDF2y48lsR8y9vqRxQ27jdWHm9cANM5fzN9kiRNCE nJtV+R1SWBW7qQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55389 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVKtA-0001lJ-RL; Fri, 18 Mar 2022 18:16:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: jgart Subject: Re: bug#54284: [PATCH] gnu: Add python-pytest-pudb. References: <20220307053725.25934-1-jgart@dismail.de> <20220315214147.17096-1-jgart@dismail.de> Date: Fri, 18 Mar 2022 23:16:03 +0100 In-Reply-To: <20220315214147.17096-1-jgart@dismail.de> (jgart@dismail.de's message of "Tue, 15 Mar 2022 17:41:48 -0400") Message-ID: <8735jeq53w.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54284 Cc: 54284@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, jgart skribis: > * gnu/packages/check.scm (python-pytest-pudb): New variable. [...] > +(define-public python-pytest-pudb > + ;; PyPi does not include tests > + (let ((commit "a6b3d2f4d35e558d72bccff472ecde9c9d9c69e5") > + (revision "0")) > + (package > + (name "python-pytest-pudb") > + (version "0.7.0") Could you clarify in a comment how this commit relates to this version number? You can remove the =E2=80=98revision=E2=80=99 variable, since it= =E2=80=99s unused. > + (file-name (string-append name "-" commit)) Rather: (file-name (git-file-name name version)). > + (synopsis "Pytest PuDB debugger integration") > + (description > + "@code{python-pytest-pudb} provides PuDB debugger integration based on > + pytest PDB integration.") ^ Extra space here. IWBN if you could add a sentence or two explaining what that means. :-) Last, please pass it through =E2=80=98guix style=E2=80=99. Could you send an updated patch? TIA! Ludo=E2=80=99.