From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 12:46:45 2022 Received: (at 54221) by debbugs.gnu.org; 3 Mar 2022 17:46:45 +0000 Received: from localhost ([127.0.0.1]:43615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPpXJ-0005Ct-Ab for submit@debbugs.gnu.org; Thu, 03 Mar 2022 12:46:45 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:34068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPpXG-0005Cj-Rw for 54221@debbugs.gnu.org; Thu, 03 Mar 2022 12:46:43 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 1tmg2700h4UW6Th01tmhHt; Thu, 03 Mar 2022 18:46:41 +0100 Message-ID: Subject: Re: [bug#54221] [PATCH 3/4] gnu: vim: Update package style. From: Maxime Devos To: SeerLite , 54221@debbugs.gnu.org Date: Thu, 03 Mar 2022 18:46:33 +0100 In-Reply-To: References: <6002b969ed2f353fef0e8fa87d4fc7d01d3344fa.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fQZU9w8BPMG0FZP7KzLu" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646329601; bh=ZQGeztsofHn4FgBdeOoeor+mfqtwlVxpDdqjiT4Ahmc=; h=Subject:From:To:Date:In-Reply-To:References; b=eo2USFOvc6qyQyEurD1B4TbPPsmtR+j12txoSfRu+W9qne0WrUe4iqluqpbCdKtZy rO2EKOt6N8gjGsV1SR6VmuR5yoSzIn3wRwne2bEglwxpD8XUs26b5Q9oz5z2ia+K7l emMQXFHeZIh4U8qt8h9mYnHn6KCdZSXs3D8Ibjqg5XiBmiti8poeqssk1HCfUHpN3I V8KgL7hqoskyCVRna04WHE2+1B0e2y/rQ6YOD2u3q9FJbVr9kzqhhAaMYK1Fkykxj5 rBCV5Pi/ccPvhL3ei95fgi54FDRsz13OPebW2ofAqMZvsBLYqVhU0fn7PmY7q/2+K/ Dq5xIq7Sn03Vw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 54221 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-fQZU9w8BPMG0FZP7KzLu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable SeerLite schreef op do 03-03-2022 om 13:49 [-0300]: > The blog post that introduces label-less inputs also introduces=20 > 'search-input-file', which made me think they were both part of the=20 > "package definition modernization process". The problem with 'which' was that it looks in 'native-inputs' (+ inputs when compiling natively), even when we need 'inputs'. To fix this, adding an 'inputs/native-inputs' argument was proposed (https://issues.guix.gnu.org/47869). That interface was considered a bit weird, so then (string-append (assoc-ref ...) "bin/...") was proposed. That's rather verbose though, so 'search-input-file' was introduced. In short, 'search-input-file' was introduced to help with locating binaries from 'inputs' (at least from my POV, shortly after ludo began using 'search-input-file' for delabelification). For looking in native-inputs (compilation tools etc.), I would prefer 'which' above the 'search-input-file' because it's a lot more concise, though I suppose there is an argument to be made for using 'search- input-file' for consistency. There's the downside of not raising an exception in case the file is not found though. However, there appears to be very few code that actually relies on the 'return #f' behaviour (search for '(or (which' and '(if (which'), so I think the behaviour can be changed without much trouble (on 'core-updates'). Greetings, Maxime. --=-fQZU9w8BPMG0FZP7KzLu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYiD++RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rurAP4mpUFtsiTZUpCfqF0YJTcX50Jd i5qX/4fMw8NF6gQ4DgEAjOs9O1WJ+cUc85zD7Ymy9GSmObdkpZjKvr+roOOZ4QI= =7vmX -----END PGP SIGNATURE----- --=-fQZU9w8BPMG0FZP7KzLu--