From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 03:48:40 2022 Received: (at 54216) by debbugs.gnu.org; 3 Mar 2022 08:48:40 +0000 Received: from localhost ([127.0.0.1]:41431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPh8a-0000Xv-5Y for submit@debbugs.gnu.org; Thu, 03 Mar 2022 03:48:40 -0500 Received: from mail-il1-f170.google.com ([209.85.166.170]:37774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPh8Y-0000Xf-AT for 54216@debbugs.gnu.org; Thu, 03 Mar 2022 03:48:39 -0500 Received: by mail-il1-f170.google.com with SMTP id i14so3490486ilv.4 for <54216@debbugs.gnu.org>; Thu, 03 Mar 2022 00:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=igeg4Ozmcltzi65vkKHFPIrMdEKojrB8a8pQBOZAS9Q=; b=dTtQ6YX2ZBtsARnAdPIqpSHf69SAaJIKD5+f20ucAvBWvBks2PdIlzN+yvJ6l1XXQF /ZjBmZQsJsUCtCWzfmUDJ6llzx50bfTZlO7iclX51JJA3Lbr2SVzKc8DwqrtuHAzfuTM 69EPW+hRehtkPzJalzAUXfCj+6Mf6XuyHZR4N4bwN1NGnW34WjZZsJDyK23l1gXQK0aY GLwAnB/pFBGy6q6Q479tCN9SXT7qhmwtEaEf3rPxMe3cbdBdxCR6nrgAHiVVAXlqo+Hl fDPNA7VIMw7vofCXMrwAQ/hyffBfgvI0cnJCN2IV0FE8+DFhhc+XG4rfkJxOEhHeveEH i6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=igeg4Ozmcltzi65vkKHFPIrMdEKojrB8a8pQBOZAS9Q=; b=PzN9puhpuMqMOmSIjxMDs2OLvqKXPp42t7hi5FnCFyK4zMhQ/ObIcHNHMl9dPMfNGB LliYjxak5DdbaHipkhREkYs4n/9chXsHgd9UT1qSi4vuysR4gw+A6n5e/h5hnr/LP4oB E0D7Ero2MZCGK+5dNABOQh1oKHu33ySacF+Gv7F6S0x9LvYKysg/hY+2JXjUAvf704qR hL49YsdBiC4NFET0kEqoVtfExSheCOS1FPwnkTTj9ntkdfVnaWg3lIRw2BX9zjlOu+HY 0xx9qyzJCEmOluQvuxiPbHT14SaiG+YrxFrHesBPWkOK5stq8UqeqkGjh7s4wHhSc43G j0Fg== X-Gm-Message-State: AOAM530JsfuF+FxtfM6XLcOCi8ZTBr8axc4iKV0K8wyw4jaulue/tF5v cTrNiUFTrEbH97I/m2pA/CBq1ckrXBnDU9EAkg0= X-Google-Smtp-Source: ABdhPJxfhYGBMhPhf3MxjAPzq1jDfXzABN9bJ/HxG6zf3BialfStng76p1Afkhv3bbXzgi2qwMVw9MGMal0q/n4AEzA= X-Received: by 2002:a05:6e02:1a0f:b0:2c1:a8db:a266 with SMTP id s15-20020a056e021a0f00b002c1a8dba266mr30837472ild.127.1646297312712; Thu, 03 Mar 2022 00:48:32 -0800 (PST) MIME-Version: 1.0 References: <20220301182848.26694-1-attila@lendvai.name> <20220301184517.13439-1-attila@lendvai.name> <992c3326a10e0bb28491f8226ebbe84aa93ad9ca.camel@telenet.be> <15fbca84-83ed-43cd-9bd4-e187ccadf4ec@www.fastmail.com> <5d684728965ec36c604e9b77f650055269e8588e.camel@telenet.be> In-Reply-To: <5d684728965ec36c604e9b77f650055269e8588e.camel@telenet.be> From: zimoun Date: Thu, 3 Mar 2022 09:48:21 +0100 Message-ID: Subject: Re: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in Guix. To: Maxime Devos Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54216 Cc: 54216@debbugs.gnu.org, Attila Lendvai , Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxime, On Thu, 3 Mar 2022 at 07:25, Maxime Devos wrote: > Leo Famulari schreef op wo 02-03-2022 om 18:50 [-0500]: > > Origin snippets should only be used to remove nonfree things > > from the upstream source code. All other changes should use > > patch files or a build phase. > > Why? If it's a source code change and it fits an origin snippet, > why not an origin snippet? Why would the source in Guix need to match > the source upstream? Because as I tried to explain here [1] ;-) 1: a) the location of patches depending of their nature is **not well-documented**, b) because it is a tension between two intentions, c) and thus we never take the time to clearly document for consistency. FWIW, it would be unfair for the patch to have the discussion here. As Leo, I also think this source modification should go to a phase. > Also, in this case, it was just copied from the 'shepherd' packages > with some slight adjustments. And I also think this recent commit 79be6a985799adc6d663890250f4fb7c12f015b4 introducing the 'snippet' is unfortunate. And it should be fixed, i.e., move the substitution to a phase. Cheers, simon