From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 09:29:56 2022 Received: (at 54216) by debbugs.gnu.org; 3 Mar 2022 14:29:56 +0000 Received: from localhost ([127.0.0.1]:41960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmSq-0007ef-A3 for submit@debbugs.gnu.org; Thu, 03 Mar 2022 09:29:56 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:38408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmSo-0007eT-G8 for 54216@debbugs.gnu.org; Thu, 03 Mar 2022 09:29:55 -0500 Received: by mail-ej1-f50.google.com with SMTP id r13so11073518ejd.5 for <54216@debbugs.gnu.org>; Thu, 03 Mar 2022 06:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SKouk2NeITzvyMLMqUltyfSZ8hykeb3Ml1ToudiOYs4=; b=P2wTE3YH6F0jdbD4rB3MBm7dF8U4hJ6JgZLacdLTp3a5JENto/RzLd+cV5NwZZ9nMF GSoXtb3ogw1dsxLQKtYVhbpIiz/bXC9W0EFElYU8q7vVb6jC43iXNz1MD1nynoyGxOSu LVAEAkKW6PsXt1WUMgdlBKLEDDYeaut2sebOqRqV65HHrNR+tYNGekG4LUWFpnQbWSzc 3gLFIt3S1F1Tkqj/3boXWQ5XhTuZ8OQqktR4kzHfIEnO4fTJgvyTV2SoinGdk++F9s6E VK2XJqTcJ/l5Yr6CpE4Il3YL4/XUCnc0Hn7itOsvn83N5l98Ax2hZkcwWHieQZtCvCBM 7Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=SKouk2NeITzvyMLMqUltyfSZ8hykeb3Ml1ToudiOYs4=; b=szINkQwqwszSdN04Dx/jexafFgFLacFwWrIoh4LUBTIkP5V1Ff+dBZrqAhy9U0zy79 Lenqbaaa7Ey3xkmtFhQAag7a3dgN2NAxzhtiD4qJ+XJ8VdQYxssT56JLR3ojwvbNLPsy l/7ufB8S4kdjcqjqluoohkT2YM8RWYtkaMWpxieLc9BsFcbrHShdKp0sovJbiv33lcLD ZVR655K4zq+t9DjyDmQntDVXrfzmsRUmMzcb7xsIBPyBHVxxJrtpNAuNRYaEhutJGysw IiTGfXnwfh0lrbTP9bVmk9MEB1vedRlT7tSbGioYA41eeEUTql6+i3t8QgacT24kIgAV J53Q== X-Gm-Message-State: AOAM530n5AwUT45ZNWtC54v7h9/0a8kIirhcFSTHldeKqFkaNHE1FRwg 9Fe3I2mr19ju0rqDO/kyu8GhYEgnjKs= X-Google-Smtp-Source: ABdhPJy0zhXwJarHNPzvPmTe53MqrXRVCl1Jchbr1lpnzoPtqUm2fnor/x/u0NzY2TRcbIccevZI7Q== X-Received: by 2002:a17:906:8299:b0:6cf:3847:284b with SMTP id h25-20020a170906829900b006cf3847284bmr27242620ejx.682.1646317788378; Thu, 03 Mar 2022 06:29:48 -0800 (PST) Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu. [89.132.245.188]) by smtp.gmail.com with ESMTPSA id n19-20020a1709067b5300b006ce36e2f6fdsm759214ejo.159.2022.03.03.06.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 06:29:47 -0800 (PST) From: Attila Lendvai To: 54216@debbugs.gnu.org Subject: [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix. Date: Thu, 3 Mar 2022 15:28:39 +0100 Message-Id: <20220303142838.9991-1-attila@lendvai.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 54216 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This cleanup is in a seprate patch because this one must go through staging. --- as promised, this is the cleanup patch for staging. gnu/packages/admin.scm | 70 +++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 42 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index dbceaca5e5..bcfef124d7 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -270,26 +270,31 @@ (define-public shepherd (package (name "shepherd") (version "0.8.1") - (source (origin - (method url-fetch) - (uri (string-append "mirror://gnu/shepherd/shepherd-" - version ".tar.gz")) - (sha256 - (base32 - "0x9zr0x3xvk4qkb6jnda451d5iyrl06cz1bjzjsm0lxvjj3fabyk")) - (modules '((guix build utils))) - (snippet - '(begin - ;; Build with -O1 to work around . - (substitute* "Makefile.in" - (("compile --target") - "compile -O1 --target")))))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://git.savannah.gnu.org/git/shepherd.git/") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1hgkbl3fyzwi5vw63kbkswnf3viyfl52c5dzkx7vbkr4sj5ysz1g")) + (modules '((guix build utils))))) (build-system gnu-build-system) (arguments '(#:configure-flags '("--localstatedir=/var") - #:make-flags '("GUILE_AUTO_COMPILE=0"))) + #:make-flags '("GUILE_AUTO_COMPILE=0") + #:phases + (modify-phases %standard-phases + ;; TODO delete this once Guile is updated to v3.0.8+ + (add-after 'unpack 'patch-source + (lambda _ + ;; Build with -O1 to work around . + (substitute* "Makefile.am" + (("compile --target") + "compile -O1 --target"))))))) (native-inputs - (list pkg-config + (list autoconf automake gettext-minimal help2man texinfo pkg-config ;; This is the Guile we use as a cross-compiler... guile-3.0)) (inputs @@ -314,45 +319,26 @@ (define-public shepherd ;; [TODO] in the manual. (define-public shepherd-for-guix (let* ((version "0.8.1") - ;; If it's an unreleased commit: + ;; A commit string, or #f if it's a release. (commit "7c380590164ea8ee40de46059d07e08a48963577") - ;; Use the below form if it's a release, and also set REVISION to #f. - ;; (commit (string-append "v" version)) - (revision "1")) + (revision "1") ; Only relevant when COMMIT is specified. + (git-ref (or commit (string-append "v" version)))) (package (inherit shepherd) - (version (if revision + (version (if commit (git-version version revision commit) version)) (source (origin (inherit (package-source shepherd)) - (method git-fetch) (uri (git-reference ;; Build from git and add Autotools inputs, to make developing ;; Shepherd easier. It enables easier package inheritance. (url "https://git.savannah.gnu.org/git/shepherd.git/") - (commit commit))) - (snippet #f) ; TODO delete this once parent is refactored. + (commit git-ref))) (sha256 - (base32 - "1hgkbl3fyzwi5vw63kbkswnf3viyfl52c5dzkx7vbkr4sj5ysz1g")))) - ;; TODO merge this back into the parent with a patch to staging. - (arguments - (append - (package-arguments shepherd) - '(#:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch-source - (lambda _ - ;; Build with -O1 to work around . - (substitute* "Makefile.am" - (("compile --target") - "compile -O1 --target")))))))) - (native-inputs - (modify-inputs (package-native-inputs shepherd) - (prepend autoconf automake gettext-minimal help2man texinfo))) - (description "A package variant for use in Guix. It helps lowering + (base32 "1hgkbl3fyzwi5vw63kbkswnf3viyfl52c5dzkx7vbkr4sj5ysz1g")))) + (description "A package variant for use in Guix. It helps lowering the build time of Guix when working on Shepherd.")))) (define-public guile2.2-shepherd -- 2.34.0