From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 21:57:54 2022 Received: (at 54069) by debbugs.gnu.org; 23 Mar 2022 01:57:54 +0000 Received: from localhost ([127.0.0.1]:42218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWqG2-0005zi-HN for submit@debbugs.gnu.org; Tue, 22 Mar 2022 21:57:54 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:40897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWqG1-0005zT-Cc for 54069@debbugs.gnu.org; Tue, 22 Mar 2022 21:57:53 -0400 Received: by mail-qk1-f169.google.com with SMTP id i65so100977qkd.7 for <54069@debbugs.gnu.org>; Tue, 22 Mar 2022 18:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p5fa0FoO5KGSuQU8atdHWhUApmV29f+Pu7zb0oWjKdc=; b=exBisEgjQcShVngNEfMiERXfPB72B1qgoHfk4p4qsQ0So8Kh+9rrX9J2qUBXCs8k6J RETBcXHLh2oQiYBH2ChGEq6ZQ/VS57rwgFySGyPaZdhqi53+mytyeqte6dqylxwWabwD B48HsZi42P3eknQm5RcX2IhSEWtgUGiexUmhE9ptV5VI9ayacYP9cyRIkZFqJ6l+ceA2 m8PoGgwIAI0yQ1hZC2HxR8tTuKGxgwT6Zkh7drwcjNSVFpfzEf7Bfmt7519/UKuyUUlO 68jeWrS1l/ReDr4ZFc+JCiw5z/6D6TzyYV5q7zU+SA2uv/sF88CvTW1T3lrskkO7rfxm bDeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p5fa0FoO5KGSuQU8atdHWhUApmV29f+Pu7zb0oWjKdc=; b=3Rpq9t7so1quaewzGCBBi8UskoF8FGgg81qpQzV6qaO15yonGQ4+jE4h6WKrliCXYC hvdFfYkY71J/M1JzwBOY8Io3dlnF32lP6guw3iSriPEyaJksAZShfGnY5O/tJif4r6p5 LTv4U5hVRjpR8lENOgJPT6YCO6R0R0OdddOta0UpJkhWWdUwqrj9JXyW6tzmKkG9A8Br moP4nJ2jqyIiGyha1miTLNRrPyAYSRTUH9AzG7/ECPVT0m95pqJYMPKRztqWD9tbiXpl m+59zcp3PO5cxp+8Sq2LCPI7JPd4Hv2U0Qh2FrbxLFSNtBIqMbDnLIac+0n0iG+9p8PM 3KWg== X-Gm-Message-State: AOAM5322oy5fHjmcWUKTYpluiZD1WLuJ/NTwImCJGxP6eq4Tx7LVW3Wz 5B0gOBSVcqZu+B7B4EIz7rE= X-Google-Smtp-Source: ABdhPJyHatafAuiU5oD/OyYTJGAyU7Y/AtsevmMUKGfSTJXsWe04l05nKkxbkKijhOwNYJecfOAVDA== X-Received: by 2002:a37:de03:0:b0:67e:4c75:9a07 with SMTP id h3-20020a37de03000000b0067e4c759a07mr15197222qkj.121.1648000667650; Tue, 22 Mar 2022 18:57:47 -0700 (PDT) Received: from hurd (dsl-10-129-199.b2b2c.ca. [72.10.129.199]) by smtp.gmail.com with ESMTPSA id s16-20020ac85cd0000000b002e1ed82f1e5sm14612041qta.75.2022.03.22.18.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 18:57:47 -0700 (PDT) From: Maxim Cournoyer To: Brendan Tildesley Subject: Re: bug#54069: [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest. References: <20220310093145.31649-1-mail@brendan.scot> <20220310093145.31649-5-mail@brendan.scot> Date: Tue, 22 Mar 2022 21:57:45 -0400 In-Reply-To: <20220310093145.31649-5-mail@brendan.scot> (Brendan Tildesley's message of "Thu, 10 Mar 2022 20:31:42 +1100") Message-ID: <87mthh1ld2.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54069 Cc: John Kehayias , 54069@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Brendan, Brendan Tildesley writes: > * gnu/packages/pciutils.scm (pciutils): > [inputs]: Add hwdata:pci for latest pci.ids file. > [arguments]: Don't install update-pciids script or it's man page. Don't > install bundled old pci.ids file, use hwdata instead. Copy the pci.ids > over so it can be gzipped. The GNU changelog idea is to stick to changes in the commit message; if explanations are needed they can go in the code as comments. Alternatively, you can also put explanations as a paragraph between the commit summary (first line) and the changelog. > --- > gnu/packages/pciutils.scm | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/pciutils.scm b/gnu/packages/pciutils.scm > index 41ba10f1e1..648d1385e4 100644 > --- a/gnu/packages/pciutils.scm > +++ b/gnu/packages/pciutils.scm > @@ -93,8 +93,13 @@ (define-public pciutils > (arguments > `(#:phases > (modify-phases %standard-phases > + (add-after 'unpack 'unbundle-pci.ids > + (lambda* (#:key inputs outputs #:allow-other-keys) ^ not needed > + (copy-file (string-append (assoc-ref inputs "hwdata:pci") > + "/share/hwdata/pci.ids") > + "pci.ids"))) I used search-input-file, making sure to use (or native-inputs inputs) as its first argument, so that it works even when cross-compiling. > (replace 'configure > - (lambda* (#:key outputs #:allow-other-keys) > + (lambda* (#:key inputs outputs #:allow-other-keys) ^ not needed > ;; There's no 'configure' script, just a raw makefile. > (substitute* "Makefile" > ,@(if (%current-target-system) > @@ -124,13 +129,19 @@ (define-public pciutils > (("^SHARED=.*$") > ;; Build libpciutils.so. > "SHARED := yes\n") > + > (("^ZLIB=.*$") > ;; Ask for zlib support, for 'pci.ids.gz' decompression. > "ZLIB := yes\n") > > (("^IDSDIR=.*$") > ;; Installation directory of 'pci.ids.gz'. > - "IDSDIR = $(SHAREDIR)/hwdata\n")))) > + "IDSDIR = $(SHAREDIR)/hwdata\n") > + ;; Don't install update script or its man page, > + ((".*INSTALL.*update-pciids .*") "") > + (("update-pciids update-pciids.8 ") "") > + (("(.*INSTALL.*)(update-pciids.8)(.*)" _ a _ b) > + (string-append a b))))) > (replace 'install > (lambda* (#:key outputs #:allow-other-keys) > ;; Install the commands, library, and .pc files. > @@ -159,7 +170,8 @@ (define-public pciutils > ,@(if (hurd-target?) > `(("hurd-patch" ,(search-patch "pciutils-hurd-fix.patch"))) > '()) > - ("zlib" ,zlib))) > + ("zlib" ,zlib) > + ("hwdata:pci" ,hwdata "pci"))) I moved hwdata to native-inputs, And pushed as 387a9772c2571d4375d6c3682c7572d12e7ec5b2 to the core-updates branch. Thank you! Maxim