From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 15 12:25:42 2022 Received: (at 53995) by debbugs.gnu.org; 15 Mar 2022 16:25:42 +0000 Received: from localhost ([127.0.0.1]:49453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU9zS-0003cU-1X for submit@debbugs.gnu.org; Tue, 15 Mar 2022 12:25:42 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:45528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU9zP-0003cI-9e for 53995@debbugs.gnu.org; Tue, 15 Mar 2022 12:25:40 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 6gRd270084UW6Th01gRd8d; Tue, 15 Mar 2022 17:25:37 +0100 Message-ID: Subject: Re: [PATCH 31/31] gnu: update rbw to 1.4.3. From: Maxime Devos To: Nicolas Graves Date: Tue, 15 Mar 2022 17:25:32 +0100 In-Reply-To: <87bky78htb.fsf@ngraves.fr> References: <20220216012409.25220-1-ngraves@ngraves.fr> <9b959752e0f2907d9c5a6de6a10aa76fa757f39b.camel@telenet.be> <87bky78htb.fsf@ngraves.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RQ7YQ64SqdMyADHw6sUO" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647361537; bh=wAn0gQxHmiwrZM5oL3NvfT3GLArxLvUeWZ4oc0FPPJM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RwLTpQ70tKdAbmTKzPzgvV6lbbi9eKLWm60JDPjWIHBM+QkgdhYzMsEifw2xOEOHZ 4/xl6o3NsLZuODNvuLmHpclNdw1cDbjKNq9MyO/Vhlz/KVE/OoGLpE2afS9El+fsdY CT7N5oWXTE9wthuZ2kfqlVFvlMaBXbsqS5HrD+Lvqgk24NCvpBpEZRfwEBpTf7ZfhZ KAuw9NUootRC6KgVLBCT+72mhJg46I2nY8+k2VjsrEluVP3AovG8Fd3JOc+tbnbo0/ BRe0F5josb7vhdnGz8gl6Y89PixzON6PDPqOF2rjuVH/LD7Pq433wIsqQ74qjYTbGa 8JYeP+lCLIDuw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53995 Cc: 53995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-RQ7YQ64SqdMyADHw6sUO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Graves schreef op di 15-03-2022 om 14:26 [+0100]: > > Wouldn't this be a problem of the 'rust-rsa' package? I would move > > this version relaxing to the 'rust-rsa' package, such that all > > dependents of rust-rsa can benefit. >=20 > I don't think that necessarily applies to every package dependent on > rust-rsa, I would rather keep it this way. Some remarks: * while cargo-build-system creates a "guix-vendor" directory, this seems an implementation detail to me, maybe one day it will switch to a {CROSS_,}LIBRARY_PATH system like gcc uses. * IIUC it does necessarily apply to every package dependent on rust-rsa, at least those using #:cargo-inputs / #:cargo-development-inputs. Empirically: I searched for "rust-rsa" in the source code of Guix. Its only user 'rbw' apparently copies the 'substitute*'. Theoretically: suppose a package rust-foo depends on rust-rsa (and for simplicity, assume that rust-rsa is its only dependency), via #:cargo-inputs / #:cargo-development-inputs. Then currently, rust-rsa builds because of its 'relax-requirements' phase, but IIUC, this is forgotten when 'rust-foo' is being built, because 'expand-crate-sources' in (guix build-system cargo) just looks at the 'source' field of 'rust-rsa' and not the build result, so the build of rust-foo would fail (unverified). * even if it's not necessary for all dependents, but only for, say, 20%, it seems more convenient to me to only have to do the substitute* in a single location (i.e., rust-rsa). An additional benefit is that, if the version requirements change at some point in the future, then the 'substitute*' only has to be adjusted in a single place. Greetings, Maxime. --=-RQ7YQ64SqdMyADHw6sUO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjC9/BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qCgAQDvbtwuUayrlbu+01zcgDFMlGkX 9XLjdRYGJdefofznSQEAiHwSTPIfH9XrQkwt7UX8OzX9Crd/QOPEGVXMM9qFdQc= =1WXG -----END PGP SIGNATURE----- --=-RQ7YQ64SqdMyADHw6sUO--