From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 15 03:45:58 2022 Received: (at 53995) by debbugs.gnu.org; 15 Feb 2022 08:45:58 +0000 Received: from localhost ([127.0.0.1]:43425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtTC-0001Le-2o for submit@debbugs.gnu.org; Tue, 15 Feb 2022 03:45:58 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:60278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtTA-0001LT-BW for 53995@debbugs.gnu.org; Tue, 15 Feb 2022 03:45:57 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id vLlu2600C4UW6Th01Llu2P; Tue, 15 Feb 2022 09:45:54 +0100 Message-ID: <7d19f36e73cbb3fb2ede965162bc2e7ac96506a8.camel@telenet.be> Subject: Re: [bug#53995] [PATCH] gnu: rbw: Update to 1.4.3 From: Maxime Devos To: Nicolas Graves Date: Tue, 15 Feb 2022 09:45:49 +0100 In-Reply-To: <87zgms4krn.fsf@ngraves.fr> References: <87r185y4gm.fsf@ngraves.fr> <52f2be01de0179ccc846ef74bca125389446b619.camel@telenet.be> <87zgms4krn.fsf@ngraves.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-lYQqwGCL/7M3+4eYzrmc" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1644914754; bh=ozGEL2GhJ0BinFLHaWfH2n9I90QCl+aNd1WeexIkmcM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=K72z8k1dv+34PHg9kttaPrSmVPEMtwkQm8660Cnpx0ccTj1XuytoUARAqZN8JIIWU 9FItJjy0+twziNzOVdS2IrvTjJkTgoALPe8Z24rYw0uktDaRN2XdZ0yOsHQBgDikp2 6UUNpOZ3EKbPaUrd5HVR9qUMLVeVnVZkCobCcw4pg5q+MxXRIG6XESQN1mLYhPEf/g KVy20ObRJdNW62E9BU3VHBjmrLJaVKknxZpE1KPX5p/SYqECdJ1R/migHXAH97E+6t WaPmstUQB/TqWAB0HAOhS7vnH7gM+YgnLwEztyWbWUQol3JZPxfsBZ5OK2ZLyv+h+i 1usxsUEvRliNQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53995 Cc: 53995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-lYQqwGCL/7M3+4eYzrmc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Graves schreef op di 15-02-2022 om 08:50 [+0100]: > Hi Maxime, >=20 > Do you mean updating packages and adding packages ? >=20 > I added two packages because they were now needed for rbw: > - rust-valuable-derive-0.1 > - rust-valuable-0.1 >=20 > Also I (maybe questionnably) updated 2 packages that are used elsewhere : > - rust-hyper-rustls-0.22 --> rust-hyper-rustls-0.23 > - rust-tokio-rustls-0.22 --> rust-tokio-rustls-0.23 I count at least 21 package updates. > The sole "patch" I can see is that of rbw in rust-apps: the only change > is the deletion of now unneeded "relax-requirements". With 'patch', I meant 0001-gnu-rbw-Update-to-1.4.3.patch. > Is it clearer ? What precisely can I split to ease the review ? Last > time I contributed, I made ~40 patches for each individual package > added, seemed too much. To ease review, I recommend 1 patch per package update and 1 patch per new package. From (guix)Submitting Patches: 13. Verify that your patch contains only one set of related changes. Bundling unrelated changes together makes reviewing harder and slower. Examples of unrelated changes include the addition of several packages, or a package update along with fixes to that package. The total size of the changes remains the same, so splitting patches does not make things =E2=80=98too much=E2=80=99 anymore than the original p= atch would be =E2=80=98too much=E2=80=99. Splitting patches makes it easier to respon= d to individual parts. Also, a commit message was missing. Additionally, I recommend setting the "--base" option of "git format-patch/git send-email" to help with rebasing. Greetings, Maxime. --=-lYQqwGCL/7M3+4eYzrmc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYgtoPRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lCcAP0XW1AQYdy66GdHyuPB4vU7j5Jo AnKj2pyNQx1mGHyGzwEA6quPib5/cc0WfCuiZj00JZ7xJ41/WHoQSbWLr51O4wI= =kPF2 -----END PGP SIGNATURE----- --=-lYQqwGCL/7M3+4eYzrmc--