From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 12 18:45:46 2022 Received: (at 53704) by debbugs.gnu.org; 12 Feb 2022 23:45:46 +0000 Received: from localhost ([127.0.0.1]:35951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJ25K-0004ih-1q for submit@debbugs.gnu.org; Sat, 12 Feb 2022 18:45:46 -0500 Received: from mail-4324.protonmail.ch ([185.70.43.24]:12285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJ25H-0004iT-NX for 53704@debbugs.gnu.org; Sat, 12 Feb 2022 18:45:44 -0500 Date: Sat, 12 Feb 2022 23:45:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1644709537; bh=FIYchh64fdXjPJZnuIqzeQdRyo/E8ZgA71AWdFVybTc=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=XfJuTskMl09Eb7z7vbzJdHoktnwCLbG6lbATodaz0emgRlhnDUwe+2mqhxTCbBr0O 2iELEVKh3kt22ra1/g/+HQm0mOQMhk5n+ut3J7axIr75FgzLu4MDcwWIbBuEq5kazu ulh3VOpNI54V1l8FgjY+vbKj8lJuZH+on/AaRul205vkQ2KgZmPX0va69c7GhVjyc1 a0vAcCcXMvSC0/BAvCe0v5pmUTnKzEKv+MPgnr+bhMgW0VJhDYQ0boW7JCD7xnwHUz U3t3kV6JxmAIZnOdDhPmz/RhwkFM8QVMmqGC2Pey2stoB7PVVhfrxOpKuejFTONHOB OS+VYo18srWOA== To: Maxime Devos From: Charles Subject: Re: [bug#53704] Bump Message-ID: In-Reply-To: <11a5c7052c3f76dcf41fc614fed551ee019c1f96.camel@telenet.be> References: <_jHX_rdAkHOB9IqHIQfXfggyuZwAL-8cC92ZuWnlLfjZtXdqUHY5XBLRjD32CGrxNx7uBzHJgAtN_YdHoifX1Y4Vhaayg_gWJX6wqPZDhx4=@protonmail.com> <33CA9DF7-1E9D-410D-9775-61825B56A0DF@lepiller.eu> <3c9dxjEeXYXD76uUQgjwTlqZOtOb7IFb8FX50AHQoH9bc-bapcr6kxnaouHjVYd3CaIPjKPiuUwZ6tx6VW-YRPKUMri5i_mLx4du5ux81a8=@protonmail.com> <11a5c7052c3f76dcf41fc614fed551ee019c1f96.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53704 Cc: "53704@debbugs.gnu.org" <53704@debbugs.gnu.org>, Julien Lepiller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Charles Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the review, Maxime! That is a lot of stuff I did not know about.= Your new version of the patch works for me except for the (list (local-fil= e part which I think should be (search-patches. What should I do about the library code duplication and licensing issues? S= hould I bring it upu with the project maintainers? ------- Original Message ------- On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos wrote: > Hi, > > I've modified the package definition and patch a bit to > > make it simpler (visualboyadvance-m-fix-rpath.patch now only removed > > things), cross-compilable (it uses cc-for-target instead of hardcoding > > "gcc" and LIBRARY_PATH is unused) and avoid using constructs that > > are being deprecated (%build-inputs --> this-package-input). > > The list+local-file will have to be replaced by search-patches. > > Cross-compilation is untested because gtk+ cannot currently be > > cross-compiled. > > It seems to work, at least the application starts, I don't have any VBA > > games to test it with. > > Greetings, > > Maxime.