From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 18:28:12 2022 Received: (at 53402) by debbugs.gnu.org; 9 Mar 2022 23:28:12 +0000 Received: from localhost ([127.0.0.1]:32826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS5j2-0006tS-FI for submit@debbugs.gnu.org; Wed, 09 Mar 2022 18:28:12 -0500 Received: from mout02.posteo.de ([185.67.36.66]:38739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS5j0-0006tD-Vn for 53402@debbugs.gnu.org; Wed, 09 Mar 2022 18:28:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9404E240103 for <53402@debbugs.gnu.org>; Thu, 10 Mar 2022 00:28:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646868484; bh=wLhIWA5jA2DgmQXye16LOOJZ9Ho0hMoeFG4yGwf77Dc=; h=Date:Subject:To:Cc:From:From; b=LnNZZ+6vK9Mdlcvp0RZn/k1NkRqiet2HVjRQe/GGXBvuFqM76lxxv6sHTTe4ZnEI3 9yo5XsIP2OEpLLcFA9m9DOT4UOPFs9x5MIBkTEnerumj4oogwmw0KiF+IygbvxpGMT SdHe5w7yjYFZvTL3opmOAHbxzepKnreDcbicJSBH2rPWp4BpDwWcIkcbSNDeyP6Az/ XkTAIbd15dvMef9Eo6uYuFoAT/woVG0NhCoskaUKYZES2UlBRMB3pM6PURgDhiLOhE Nj0DjEjIvPJzIvT+6yDEY3Vp+emgc1nQgLvEIPt/ewkbVzUeMBZGZeLwk8l9nh7xWn b4jyyjnK+H8JA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KDSzk4y46z6tmp; Thu, 10 Mar 2022 00:28:02 +0100 (CET) Message-ID: Date: Wed, 9 Mar 2022 23:28:00 +0000 MIME-Version: 1.0 Subject: Re: bug#53402: Add python-mne Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <1161a7298bbbbe87ce48f4e3e4846021204ae1df.camel@posteo.net> <221569342c7c44d5ed2ddd1ce0e56903d3cda0b2.camel@planete-kraus.eu> <87bkyiiwg2.fsf_-_@gnu.org> From: Vinicius Monego In-Reply-To: <87bkyiiwg2.fsf_-_@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53402 Cc: Vivien , 53402@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 06/03/2022 6:48 PM, Ludovic Courtès wrote: > Hello! > > Vinicius, could you take a look at v5 of this patch series? > > Thanks for reviewing! > > Ludo’. Hi Ludo, Vivien. Sorry for the long wait. I will be busy until mid-April. I did review the patches earlier and LGTM apart from minor style/lint and description issues, but I could fix that before committing. I saw that someone pushed a wip-python-mne branch and thought they were taking care of this. I have some questions for other maintainers, like 1. Is it OK to have that many bootstrap packages for pytest modules (patches 8 to 16) and in files different than where they are supposed to be (e.g. decopatch-minimal in python-check to bootstrap pytest-harvest)? It seems that there are no other options in this case though. 2. Should python-no-verison (patch 22) be a public variable? It is an example package, doesn't seem to be useful to expose it. If it's OK I could push the series up to patch 26. I haven't reviewed 27 and on in v5. 3. Not a question but it would be good to review FSDG status of python-mne, since it contains code to download non-free data.