From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 17:56:25 2022 Received: (at 53279) by debbugs.gnu.org; 16 Jan 2022 22:56:25 +0000 Received: from localhost ([127.0.0.1]:44433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ERk-0005cR-Rg for submit@debbugs.gnu.org; Sun, 16 Jan 2022 17:56:25 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ERi-0005cC-Af for 53279@debbugs.gnu.org; Sun, 16 Jan 2022 17:56:23 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6C011FF802; Sun, 16 Jan 2022 22:56:15 +0000 (UTC) From: Nicolas Goaziou To: Niklas Eklund Subject: Re: [bug#53279] [PATCH] gnu: Add emacs-dtache References: <87pmotpfam.fsf@posteo.net> <87czktkr40.fsf@posteo.net> <877db13p1e.fsf@posteo.net> <87a6fw3fxa.fsf@nicolasgoaziou.fr> <87ee587itt.fsf@posteo.net> Date: Sun, 16 Jan 2022 23:56:14 +0100 In-Reply-To: <87ee587itt.fsf@posteo.net> (Niklas Eklund's message of "Sat, 15 Jan 2022 22:08:46 +0000") Message-ID: <87tue3i92p.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53279 Cc: 53279@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Niklas Eklund writes: > Ah good to know, I have updated that part now. Thanks for the update. I merged the consecutive phases with emacs-substitute-variables for clarity, and enabled tests with "#:tests? #true". I'm sending the package definition in its current state: --8<---------------cut here---------------start------------->8--- (define-public emacs-dtache (package (name "emacs-dtache") (version "0.3") (source (origin (method git-fetch) (uri (git-reference (url "https://gitlab.com/niklaseklund/dtache") (commit version))) (file-name (git-file-name name version)) (sha256 (base32 "0f2yxrqfkslif2y88x9vlpshadifppxw6yl1rrf1qzfjy6cv144n")))) (arguments (list #:tests? #true #:test-command #~(list "ert-runner") #:phases #~(modify-phases %standard-phases (add-before 'install 'install-dtache-env (lambda _ (install-file "dtache-env" (string-append #$output "/bin")))) (add-after 'unpack 'locate-dtach (lambda* (#:key inputs #:allow-other-keys) (make-file-writable "dtache.el") (emacs-substitute-variables "dtache.el" ("dtache-env" (string-append #$output "/bin/dtache-env")) ("dtache-dtach-program" (search-input-file inputs "/bin/dtach")) ("dtache-shell-program" (search-input-file inputs "/bin/bash")))))))) (build-system emacs-build-system) (native-inputs (list emacs-ert-runner)) (inputs (list dtach)) (home-page "https://gitlab.com/niklaseklund/dtache") (synopsis "Run and interact with detached shell commands") (description "The dtache package allows users to run shell commands detached from Emacs. These commands are launched in sessions, using the program dtach.") (license license:gpl3+))) --8<---------------cut here---------------end--------------->8--- Unfortunately, one test is failing with the following output: --8<---------------cut here---------------start------------->8--- .......Test dtache-test-dtach-command backtrace: Test dtache-test-dtach-command condition: (ert-test-failed ((should (equal expected-concat (dtache-dtach-command session t))) :form (equal "dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" "/gnu/store/prhk20g1yp8qbn4rj5h25cdpimxynq3d-dtach-0.9/bin/dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log") :value nil :explanation (arrays-of-different-length 268 326 "dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" "/gnu/store/prhk20g1yp8qbn4rj5h25cdpimxynq3d-dtach-0.9/bin/dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" first-mismatch-at 0))) F................ --8<---------------cut here---------------end--------------->8--- Do you think this can be fixed? Or shall we skip that test? Regards, -- Nicolas Goaziou