From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 18 12:33:54 2022 Received: (at 53144) by debbugs.gnu.org; 18 Jan 2022 17:33:55 +0000 Received: from localhost ([127.0.0.1]:51558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sMk-0007uJ-Kl for submit@debbugs.gnu.org; Tue, 18 Jan 2022 12:33:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:56786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sMi-0007u6-S1 for 53144@debbugs.gnu.org; Tue, 18 Jan 2022 12:33:53 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C6489847; Tue, 18 Jan 2022 18:33:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nGHZDx2Y_ygl; Tue, 18 Jan 2022 18:33:46 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DEAE52D7; Tue, 18 Jan 2022 18:33:45 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#53144: [PATCH 0/13] Make more git-using packages auto-updatable References: <20220109191015.33058-1-maximedevos@telenet.be> <20220109191015.33058-10-maximedevos@telenet.be> Date: Tue, 18 Jan 2022 18:33:45 +0100 In-Reply-To: <20220109191015.33058-10-maximedevos@telenet.be> (Maxime Devos's message of "Sun, 9 Jan 2022 19:10:12 +0000") Message-ID: <87lezddk3q.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: C6489847 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53144 Cc: 53144@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Maxime Devos skribis: > This is currently pointless, because no updater returns such versions. s/pointless/unused/ :-) > A future patch will introduce an updater returning such versions. > > * guix/upstream.scm > (git-version-regexp): New variable. > (maybe-git-version, maybe-git-version->revision) > (maybe-git-versions->revision-replacements): New procedures. > (update-package-source): Use 'package-definition-location' instead of > 'package-location'. Also replace the revision. Please mention tests/upstream.scm too. Otherwise LGTM. Ludo=E2=80=99.