From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 09 16:16:05 2022 Received: (at 53144) by debbugs.gnu.org; 9 Jan 2022 21:16:05 +0000 Received: from localhost ([127.0.0.1]:51456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6fXo-0003PY-Ts for submit@debbugs.gnu.org; Sun, 09 Jan 2022 16:16:05 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6fXm-0003Hd-Oo for 53144@debbugs.gnu.org; Sun, 09 Jan 2022 16:16:03 -0500 Received: by mail-wr1-f65.google.com with SMTP id v6so23064125wra.8 for <53144@debbugs.gnu.org>; Sun, 09 Jan 2022 13:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=2YHTPqZq6nNsyuh2AVtocD0anax4z0XgUL58CaQpwRg=; b=Gmea0PlC99FPLeuDn+Y9bk9Bbm9Y2l5DRNxDCu/TDKUaG+hNHRiWyYAXheenJsClLO 5iqNJpwUgS1VN1iva0NBfVEXWEv5APIIlxQsr285IasvDgg+yU+QD4sxMaR1CmdHO6nB BAl2hmvIzbnB08+Mrs3H31iXoowQvRajrY12sT1IS95eBjg0sEdo9bvPG3qntOK2I/hy W+iYJdIqmH+ALUCzlwR3hwMRo1xWLRy3LkFZf47M5rNpCNzPvigvCre/hG/u3shyMxhA uP3Frus9fe8lgjQWpJfULfejkQgmA1Mrae8wNf4yKyKtiUkDxjszRcGhyWMVFV1fhGqe 41Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=2YHTPqZq6nNsyuh2AVtocD0anax4z0XgUL58CaQpwRg=; b=DuMZjEx3GVKpW3FjgRalKljGFFhxgHak9n6knHLor1jWhpvvPSCo1dks3mqFLIakZK 6U2bkxeriUC+R4q2Q8wKqIf+lNUFse1zlIoC43ECUBOpNSfeo1sAD9xeal7ySd4EmVmP t3UsGM8F6uW/yoXWuVHx0qbBUZ5QJW5HR8jsMJbqafcP0T0k8JOG89ZliuCDKHm0tbwo GKC2erksawllv+I6Ec//M4/j3LitIypvfHhDFmOTHbh+wewGQwyy8sEVweZVC0tLhMZB 1kjx1uevXrv9gD2eiE6pv/aGLcHqeEFsfOKgfOvI19DKzeWYL752zMhfj7QNy5g8XHPR 2B3w== X-Gm-Message-State: AOAM532p8k/oYw5EK8R2IDfj2SvwORZwGJ8Vdh+KMWs22fq3SoA9XO/Z m73ShpjYAVXEgQyAJfpjzRU= X-Google-Smtp-Source: ABdhPJwgp/khpk2ofUsNRRSTdvUZ+Q5hq6Zhe51q1tNLRwJ3O3dlykYh7PXC8bTZE+2kzyRzPzWdnQ== X-Received: by 2002:a05:6000:1acb:: with SMTP id i11mr60583334wry.244.1641762956651; Sun, 09 Jan 2022 13:15:56 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h2sm4973808wrr.96.2022.01.09.13.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 13:15:56 -0800 (PST) Message-ID: Subject: Re: [PATCH 01/13] doc: Give some tips on Minetest packaging. From: Liliana Marie Prikler To: Maxime Devos , 53144@debbugs.gnu.org Date: Sun, 09 Jan 2022 22:15:54 +0100 In-Reply-To: <20220109191015.33058-1-maximedevos@telenet.be> References: <20220109191015.33058-1-maximedevos@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53144 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 09.01.2022 um 19:10 +0000 schrieb Maxime Devos: > * doc/contributing.texi (Minetest Packages): New section. > * doc/guix.texi: Copyright update. > --- >  doc/contributing.texi | 42 > ++++++++++++++++++++++++++++++++++++++++++ >  doc/guix.texi         |  2 +- >  2 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index 72f5ce1e0e..5b91fc7867 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -394,6 +394,7 @@ needed is to review and apply the patch. >  * Synopses and Descriptions::   Helping users find the right > package. >  * Snippets versus Phases::      Whether to use a snippet, or a build > phase. >  * Emacs Packages::              Your Elisp fix. > +* Minetest Packages::           Building blocks. >  * Python Modules::              A touch of British comedy. >  * Perl Modules::                Little pearls. >  * Java Packages::               Coffee break. > @@ -703,6 +704,47 @@ When encountering problems, it is wise to check > for the presence of the >  file, and whether any dependencies and their versions listed therein > are >  satisfied. >   > +@node Minetest Packages > +@subsection Minetest Packages > +@cindex minetest, packaging > + > +A Minetest mod @code{foo} is named @code{minetest-foo} -- the author > +name from ContentDB is not included, unless required to resolve a > name > +collision. > + > +Sometimes, it might be unclear what the version of a Minetest mod > is. > +For example, ContentDB and the importer reports 2020-01-01, but > +according to the forums the version is 2.1.  Usually, in these cases > the > +version on ContentDB is the newest and intended for distribution. As > +such, you can use the version from ContentDB without any special > +comments. We might want to quote an authoritative resource on that, perhaps in the footnote? > +@c Currently it's always checked out from git, but in principle > +@c tarballs could be used. > + > +Even though the source code is often checked out from version > control, > +it is not necessary to use @code{git-version} or @code{hg-version}: > the > +releases on ContentDB are formal releases; in fact they are > upstream's > +official source of Minetest packages and they are not mutated in- > place. > + > +@c Example (zip): mods by TenPlus1 > +@c Example (git): basic_materials, ethereal > +While ContentDB provides the source code of packages in zip form, it > is > +recommended not to use these, because users can and do delete old > +versions.  Likewise, sometimes the maintainer initially did tag > versions > +but later stops doing so, breaking @command{guix refresh -u}.  As > such, > +it is recommended not to use git tags in @code{origin} records and > +instead refer to the commit directly. This combination of version+commit is something I'd generally discourage (my reasoning for doing so already explained elsewhere), so to me it might make sense to still explicitly point attention to it. Perhaps setting a package-property such as (upstream . contentdb), which would also make it clear why we don't e.g. want the latest-git updater to apply? Otherwise LGTM.