From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 08:13:19 2022 Received: (at 53060) by debbugs.gnu.org; 17 Jan 2022 13:13:20 +0000 Received: from localhost ([127.0.0.1]:45123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Rp1-0004XX-Ma for submit@debbugs.gnu.org; Mon, 17 Jan 2022 08:13:19 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:43430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Roz-0004XF-LY for 53060@debbugs.gnu.org; Mon, 17 Jan 2022 08:13:18 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 448A552F; Mon, 17 Jan 2022 14:13:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lC-1nE73ZeKf; Mon, 17 Jan 2022 14:13:11 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 7B9504C4; Mon, 17 Jan 2022 14:13:11 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxime Devos Subject: Re: bug#53060: [PATCH 0/2] Allow the github updater to update git sources References: <538acb9dc52f6992a5a65846db48f8b7382fb1be.camel@telenet.be> <87wnizz5kr.fsf@gnu.org> <92f867a635d71b427a97012e308ed6578b3db4f4.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Niv=C3=B4se?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Jan 2022 14:13:11 +0100 In-Reply-To: <92f867a635d71b427a97012e308ed6578b3db4f4.camel@telenet.be> (Maxime Devos's message of "Mon, 17 Jan 2022 10:12:46 +0000") Message-ID: <87o84apkt4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 448A552F X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53060 Cc: 53060@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Maxime Devos skribis: > tests/cpan.scm uses 'with-http-server', which I do not find ideal > because the answers the HTTP server gives depend on the order the > HTTP server was queried, without verifying the URI. Mocking > 'http-fetch' allows me not to worry about ordering and allows verifying > the URI. Good point. > It might be possible to modify 'with-http-server' into something > (with-http-server*?) that allows looking at the HTTP headers and URI > and dynamically generate a response based on that. Yes, that=E2=80=99d be great. > Due to the mocking, %github-api isn't truly necessary, but having > "https://api.github.com" in a single location helps avoiding typos > like writing "http://" instead of "https://" somewhere, or adjusting > the domain name if GitHub decided to change it for whatever reason > (hopefully unlikely?), or if Tor becomes very popular among the general > public and GitHub has an ".onion" address, then it could be changed to > the ".onion" address easily, ... Yes, and also, setting =E2=80=98%github-api=E2=80=99 makes sure we don=E2= =80=99t inadvertently talk to the real GitHub (there was a bug along these lines in the tests of one of the importers a while back.) Thanks, Ludo=E2=80=99.