From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 22 09:28:10 2021 Received: (at 52731) by debbugs.gnu.org; 22 Dec 2021 14:28:11 +0000 Received: from localhost ([127.0.0.1]:57168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n02bC-00043b-Jc for submit@debbugs.gnu.org; Wed, 22 Dec 2021 09:28:10 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:40523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n02bB-00043O-9t for 52731@debbugs.gnu.org; Wed, 22 Dec 2021 09:28:09 -0500 Received: by mail-wr1-f42.google.com with SMTP id q16so5284773wrg.7 for <52731@debbugs.gnu.org>; Wed, 22 Dec 2021 06:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=4vn3aO5mTGnI3Egx83ZUOMPUG4KRXXb+xZzpG/9L1x0=; b=H05TOhe0VT4JlSRRVjOOUtpQrMAY/BgAP+UG3nJsQpoTlpZLoDJ9H/4nUgEZmtm/CK mVWKPWld4Cr+7Hu8DDFii0Spen8zzUbJ9hYOpNYaOejMAIiE5OTt6EdVcbqgJ7ZrZzX4 M2e6tto6TE5D4MO2wejqilZBsbsFW9Uir5p8XgSKdTgQJX05BUcWymX7ocH9tRKNjLUm 5d3Fxmb9ANFS7aCwoPd4WWNERko7osFocbWaj+Ys1Le6p+j6mK36kqFV5fif1HuRa3nE PyW4BLTippO+rVAfGHM5OdrYLi6lWMXLpjby5GSLiNG1bnxjUE5pSEb+u3hOxqUSl3lN Z4vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=4vn3aO5mTGnI3Egx83ZUOMPUG4KRXXb+xZzpG/9L1x0=; b=Rykf8aJcgrrNfAgM2wSyFU+76f2pO1o+rFGXOzeDeGOZNb7GiAWvL1F+0B4kUNLSaW 9rXvnE0+UkJ8jnKbkMplP1EbL7r79BCpwTnxCVsiZvtD8PhBJzQhDvGwRJL5SQann9dZ tayat74RTZbopcWrVYHcyWEJsMnJCCDcXpxzL+706xrv/8hZgWk6M93z5lNCvI/yqw0V X+UkW7ktOJQ9VMz1H7tvNP+wqD3eluISkfmG23LZAng/6gKeg2xhWwseWJdXyLLrkYAh vnQ8TNRhrf3ZSdVTdWP2fpnQzH6uiwC+FVG8OFxZ9OXps0m6uVRwbI0j5pMvwhzhsNnl pLhw== X-Gm-Message-State: AOAM532FPHPpHVU9vwfh2gUCs1pmywlUCsJsg95qTkIgLyrcu7U3qez0 YZUd5pRjPkRI7WVVuD+5smE+t0YTghk= X-Google-Smtp-Source: ABdhPJxes31piN6jfRWmnXHjLnMTpXd9qhuLm8/R6l/l97UY+IrDsl3l0GSJaEha+RmRurqJ2sTUBA== X-Received: by 2002:a5d:64ac:: with SMTP id m12mr2329165wrp.659.1640183283376; Wed, 22 Dec 2021 06:28:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id o8sm2525548wry.20.2021.12.22.06.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 06:28:03 -0800 (PST) From: zimoun To: Xinglu Chen , Liliana Marie Prikler , 52731@debbugs.gnu.org Subject: Re: [bug#52731] [PATCH] import: texlive: Check if Subversion is installed. In-Reply-To: <87a6gswyb4.fsf@yoctocell.xyz> References: <132d0f25d38be2a34abec3c43e4d685cdd0abe65.1640163645.git.public@yoctocell.xyz> <62f7af317db40e543c8e329ccf86849cda08eca4.camel@ist.tugraz.at> <87a6gswyb4.fsf@yoctocell.xyz> Date: Wed, 22 Dec 2021 15:23:54 +0100 Message-ID: <867dbwsop1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Your patch is an improvement considering this old discussion [1]. 1: Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.42 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.42 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 52731 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi, Your patch is an improvement considering this old discussion [1]. 1: On Wed, 22 Dec 2021 at 14:42, Xinglu Chen wrote: > Which =E2=80=98svn-fetch=E2=80=99 are you referring to (there are two AFA= ICS)? The > Texlive importer uses =E2=80=98download-multi-svn-to-store=E2=80=99, whic= h itself uses > =E2=80=98svn-fetch=E2=80=99 from (guix build svn), but it requires the = =E2=80=98svn=E2=80=99 program to > be in PATH. > > There is another =E2=80=98svn-fetch=E2=80=99 procedure, in (guix svn-down= load), but that > one returns a fixed-output derivation, so it can only be used if we > already know the hash (which we don=E2=80=99t, that=E2=80=99s why we are = fetching the > SVN repo). The one in (guix svn-download) uses under the hood (guix build svn), if I read correctly: --8<---------------cut here---------------start------------->8--- #~(begin (use-modules (guix build svn)) (svn-fetch '#$(svn-reference-url ref) '#$(svn-reference-revision ref) #$output #:svn-command (string-append #+svn "/bin/svn") #:recursive? #$(svn-reference-recursive? ref) #:user-name #$(svn-reference-user-name ref) #:password #$(svn-reference-password ref))))) --8<---------------cut here---------------end--------------->8--- Anyway. :-) > Importers that fetch a Git repo don=E2=80=99t need =E2=80=98git=E2=80=99 = to be in PATH since > they use the Guile-Git bindings to libgit2. But we don=E2=80=99t have Gu= ile > bindings to SVN (or Hg, CVS, Bzr), so the program has to be installed on > the host system. I think it is not related how the call is done, here (invoke =E2=80=9Csvn= =E2=80=9D =E2=80=9Cexport=E2=80=9D =E2=80=A6) and not (libsvn-export =E2=80=A6). In the snippet above, #+svn is transparently picked from the current subversion package. Maybe the bit --8<---------------cut here---------------start------------->8--- (define (subversion-package) "Return the default Subversion package." (let ((distro (resolve-interface '(gnu packages version-control)))) (module-ref distro 'subversion))) --8<---------------cut here---------------end--------------->8--- could go to =E2=80=99(guix build svn)=E2=80=99, used overthere instead of = =E2=80=9C#:key (svn-command "svn")=E2=80=9D; and maybe exported if needed. WDYT? 1: Cheers, simon