From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 02:56:33 2021 Received: (at 52730) by debbugs.gnu.org; 24 Dec 2021 07:56:33 +0000 Received: from localhost ([127.0.0.1]:35582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0fRJ-0004G7-6t for submit@debbugs.gnu.org; Fri, 24 Dec 2021 02:56:33 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0fRF-0004Fr-Bn for 52730@debbugs.gnu.org; Fri, 24 Dec 2021 02:56:31 -0500 Received: by mail-wr1-f68.google.com with SMTP id t26so16103202wrb.4 for <52730@debbugs.gnu.org>; Thu, 23 Dec 2021 23:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=4FUp5nkWDGbvquyQk9ulLOb1H3wQIM7HdYqNh8ET8CY=; b=YWlhAGgcsRtQWAhirTsBob+WTYg7dmwILjVp4LdPeglD45dw10op+A9GQS2KVxFMAj ggdEm3bq+Pt75PJ7su40TVvoy9efP7ExFII62pHGxwhUAKqcTX/LuwxvP8UrHxiVkZzG DnS7Ohkca/36TBYxeqsVpBClJFoP09FAh8ncxWX11QZW5LTzL3dPlNKW2WE6E7m8QwQR jBdSWMRj+ST9qAPEj+aubpFEMJk9eRHwHJoFt3QkbJmGv29qDbwZG5lbEYvGQnsWQW0C HITPjsBLFNZIrJXFU9ayMPuS4jP7JQrtB1uqi1kpdoDw1BOz67kTSvsIHjuzHErZCIaK A28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4FUp5nkWDGbvquyQk9ulLOb1H3wQIM7HdYqNh8ET8CY=; b=fklWnWI/ud7t3GYJr7rBEU0sMGGRLEBwRY7EfucUqYpUwKxyhh7XijJ07HpDyR5W1j 594Vb/hH8bU+PVaTPmFAMJCteT2q1crkCxPrRSGbtEB52qXRsBiVB6rWCZPn1ugoHIt/ 2iQefoMgPPc3X6KQGTU/reQXyVsmKztnWXk311dhiadKDVOPM+AYb3E7St0arvKk/9Li JrG8d7FBaH4hgfND+hc4f1o3ykXNjW09nnevygfMuzd2/1IZ+WBezO5g1+/R2MVr3O3f GbdsdB3GQWdEijH+6r+svJ06ms20yaORrvb2JnN4hb1xJ/W5ODEApe0Hiwcu8UpN0f/z kgfA== X-Gm-Message-State: AOAM533nDPb6d3ojtFlX6eNFKVrMnenqh0xiwUTXPjkusKYSfy/T0llP +FSD/bY8WdG/7kq10A6O+Xk= X-Google-Smtp-Source: ABdhPJwnuArmWQaaJyZBnxmOWUZv6AB3YINpwBh+lSjEPfvGCrpnEdh7hNM865R3P+A9OPZujud86g== X-Received: by 2002:a05:6000:18a2:: with SMTP id b2mr4034174wri.277.1640332583338; Thu, 23 Dec 2021 23:56:23 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d143sm6606784wmd.6.2021.12.23.23.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 23:56:22 -0800 (PST) Message-ID: Subject: Re: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. From: Liliana Marie Prikler To: Jack Hill Date: Fri, 24 Dec 2021 08:56:21 +0100 In-Reply-To: References: <20211222033442.14793-1-jackhill@jackhill.us> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52730 Cc: 52730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jack, Am Freitag, dem 24.12.2021 um 01:37 -0500 schrieb Jack Hill: > On Fri, 24 Dec 2021, Jack Hill wrote: > > I've looked at it for a little bit now, but I'm afraid that I'm > stuck. I tried setting the default to #f (which may have been > happening implicitly anyway): Yes, if you don't supply an optional argument in Guile (or I guess in Scheme generally), that argument gets #f as value. > ``` > (define-public gst-plugins/selection >    (lambda* (pkg #:key plugins (configure-flags #f)) >      "Build PKG with only PLUGINS enabled.  Optionally, if CONFIGURE- > FLAGS are > given, also pass them to the build system instead of the ones used by > PKG." >      (package/inherit pkg >        (arguments >         (substitute-keyword-arguments (package-arguments pkg) >           ((#:configure-flags flags `(,@(or configure-flags '()))) >            `(append >              (list >               ,@(map (lambda (plugin) >                        (string-append "-D" plugin "=enabled")) >                      plugins)) >              (list ,@(or configure-flags flags)))) >            ((#:phases phases) >             `(modify-phases ,phases >                (add-after 'unpack 'disable-auto-plugins >                  (lambda _ >                    (substitute* "meson_options.txt" >                      (("'auto'") "'disabled'"))))))))))) > ``` > > but that still gives me the "bad syntax in form quote" message. I can > keep thinking about it, but if someone else knows the solution, I'd > be happy to learn from you :) I swear this used to work before the c-u-f merge. There might be a problem mixing this with gexps or something I didn't account for back then.