From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 09:25:09 2021 Received: (at 52204) by debbugs.gnu.org; 2 Dec 2021 14:25:09 +0000 Received: from localhost ([127.0.0.1]:47021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msn1I-0007Mo-UB for submit@debbugs.gnu.org; Thu, 02 Dec 2021 09:25:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msn1G-0007MR-TI for 52204@debbugs.gnu.org; Thu, 02 Dec 2021 09:25:07 -0500 Received: from [2001:470:142:3::e] (port=45972 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msn1B-0001pU-Hp; Thu, 02 Dec 2021 09:25:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=L8lOFOzpROU+/f8QhD9IRmFXdWHA9GDhL2K0I0yyK3Q=; b=H031crq/pMBg3Uu73CpW MU4G1xfXzlbHihBIGzOTZdQi1Xgd5I2IUHZJGl2VakSRJz23zND2LJj1YR8ETHVR7a0YNXIru+Af6 atc8GjhA2kU82Fvv25L7hkgShBBuv6KBYiWZJPc5NC9UL6wNa9kWCO5BDeaNBld9+5rYhYkasNbAi fFZYVJWAchwOMLP0C0EeOKqX58QZdNeej8fIJCMHqR4CfSoC+w4Hp1THQjkdd4I9TlXoI5fhRfq0P FpUFGsfXhvPNgy9lgFSLDqAjX7Jbgg2X1bPqgt+EHRkmi5KY+rkwlqO+iXHJberrbI33K6K3joSlQ YVSGiAWEK0/glw==; Received: from [2a01:e0a:19b:d9a0:2ddb:d3d2:32e8:d31a] (port=48720 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msn17-0006c8-2c; Thu, 02 Dec 2021 09:24:59 -0500 From: Mathieu Othacehe To: Attila Lendvai Subject: Re: bug#52204: [PATCH] guix system vm: Add --no-graphic CLI argument. References: <20211130191312.32131-1-attila@lendvai.name> Date: Thu, 02 Dec 2021 15:24:55 +0100 In-Reply-To: <20211130191312.32131-1-attila@lendvai.name> (Attila Lendvai's message of "Tue, 30 Nov 2021 20:13:13 +0100") Message-ID: <87tufrw0co.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52204 Cc: 52204@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > * gnu/system/vm.scm (system-qemu-image/shared-store-script): Also add the > '-nographic' qemu argument when called with #:graphic? #false. > * guix/scripts/system.scm (system-derivation-for-action): Propagate > the #:graphic? keyword arg. > (perform-action): Add and propagate the #:graphic? keyword arg. > (show-help): Add --no-graphic CLI arg. > (%options): Process the new --no-graphic CLI arg. > (process-action): Feed in the CLI arg through the #:graphic? keyword arg. This looks fine. Could you send an updated patch with the associated documentation update? Thanks, Mathieu