From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 17 12:47:23 2021 Received: (at 51923) by debbugs.gnu.org; 17 Nov 2021 17:47:23 +0000 Received: from localhost ([127.0.0.1]:33853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnP1m-0008QD-Vq for submit@debbugs.gnu.org; Wed, 17 Nov 2021 12:47:23 -0500 Received: from tobias.gr ([80.241.217.52]:44282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnP1i-0008Py-P6 for 51923@debbugs.gnu.org; Wed, 17 Nov 2021 12:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=cAS4JJLxxf4V9 EsIoMAG4sq/2dwEbdAbJeA4CcCityQ=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=WYwvmPVDKDFSrgpL05KMyj7uFcPj1BWZmb370paTr lQBAoeDl7lKKx3dcIaMleNXLB6onjlS+DIHhW99NnNyvi/C51Ffh8a5WwCaJ3OOyGRYszs CH1/LDCYyn55BWNG6DZ61zswFvQuuWtfc4n/p+RCI5SZoVgEXSWpC/BFM/WBouCqHANm4K 4aVHtkZYNPIGyeryyCQcP5JAfeBXJ1htFmIMKX8Nn//LvhTvNbsQBrdexHeMRU3pRNYLxr wuzi5blRhYJYjuoW1or50qO8rqk7RATI6bdlvw1rMB1qX5FDaW5kDjthskVJg/KalEqMjm xho/ZtUY4KZkXg8w1iiug== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id a4d31437; Wed, 17 Nov 2021 17:47:15 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 17 Nov 2021 18:47:15 +0100 From: Tobias Geerinckx-Rice To: phodina Subject: Re: [bug#51923] [PATCH] gnu: Add megapixels. In-Reply-To: <1vMgyrQNafwkMS0fIpN4mfDx99qF7xXbrXm_sCn6ysww4GrF4zowVOX2LzUzvgC33fu6zlCrPKQTpas0kymx5ME2BmRRNON5m0cmlh9Lrbs=@protonmail.com> References: <1vMgyrQNafwkMS0fIpN4mfDx99qF7xXbrXm_sCn6ysww4GrF4zowVOX2LzUzvgC33fu6zlCrPKQTpas0kymx5ME2BmRRNON5m0cmlh9Lrbs=@protonmail.com> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51923 Cc: 51923@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Petr, 'Nother quickie. On 2021-11-17 17:07, phodina via Guix-patches via wrote: > The problem is in the updater not handling the url > https://git.sr.ht/~martijnbraam/megapixels. Good thing 'he development and maintainership of Megapixels has been moved to gitlab.com/postmarketos/megapixels' then :-) Could you update the URL and try again? If you want you can report and/or investigate Guix's apparent failure to deal with sr.ht separately. > + (file-name (string-append name "-" version ".tar.gz")) ^^^^^^^^^ Use git-file-name here for convenience and to reduce the chances of such paste-os. > + (native-inputs `(("pkg-config" ,pkg-config) > + ("gtk:bin" > + ,gtk "bin") ; for gtk-update-icon-cache > + ("glib:bin" > + ,glib "bin") ; glib-compile-schemas, etc. > + ("desktop-file-utils" > + ,desktop-file-utils) ; for > update-desktop-database > + ("zbar" ,zbar) > + ("libtiff" ,libtiff) > + ("cmake" ,cmake))) Please add a newline after native-inputs so you don't have to split inputs over 2 lines like this. Since we're here anyway, order these alphabetically. > + (inputs `(("libhandy" ,libhandy) > + ("perl-image-exiftool" ,perl-image-exiftool) > + ("imagemagick" ,imagemagick) > + ("libraw" ,libraw) > + ("gtk" ,gtk))) Same newline. > + (synopsis "Camera application") So... ignoring the redundant 'application', this is a one-word synopsis. This seems to be for mobile devices, so 'Camera applications for mobile devices', I guess. > + (description "This package provides camera application that knows > +how to deal with the media request api.") Whose obscure 'media request API'? Why does that matter? Etc. This seems (more?) pertinent: - Megapixels only captures raw frames and stores .dng files. - It captures a 5 frame burst and saves it to a temporary location. - It runs a (customisable? dunno) postprocessing script to generate the final JPEG file and saves it to the Pictures directory. - It uses OpenGL to debayer the raw sensor data for the preview. Etc. Descriptions should not be 1-2 lines long. > + (home-page "https://git.sr.ht/~martijnbraam/megapixels") Also update to GitLab? I'll build this later today, but I don't expect to find any issues with the package :-) Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity.