From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 21:07:16 2021 Received: (at submit) by debbugs.gnu.org; 30 Nov 2021 02:07:16 +0000 Received: from localhost ([127.0.0.1]:39895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrsY7-0000lU-Vs for submit@debbugs.gnu.org; Mon, 29 Nov 2021 21:07:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:35438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrsY5-0000lB-JZ for submit@debbugs.gnu.org; Mon, 29 Nov 2021 21:07:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrsY5-0005Of-Fy for guix-patches@gnu.org; Mon, 29 Nov 2021 21:07:13 -0500 Received: from mx1.riseup.net ([198.252.153.129]:36238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrsY3-0007ga-0i for guix-patches@gnu.org; Mon, 29 Nov 2021 21:07:13 -0500 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4J35FR6Yt4zDyP5; Mon, 29 Nov 2021 18:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1638238027; bh=DDSCI/B7zH9oHaB9DCGnTEJrX11sqneY+yMiadZZEso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qRvN60ntX17DvqtwKsWGxpSQwqgJ1Il+mmgRUDa9Te+KnDVAoD0agUs00CKGcEiCg I2D//X4CBz6GmBSvZ1yw7NIrNwuPfSJ4pj+k4UQb97SSWuuW54/zOMNPxYsOLBA7RK sXjOI4t1X4M9ssoag4f29ofCuO140TtwFtWra4kY= X-Riseup-User-ID: DC3B421FDA86FC4D4742C77BE64D3BA90DAFD1374D1D387EB35E88BD6A33A07F Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4J35FQ57GNz5vcH; Mon, 29 Nov 2021 18:07:06 -0800 (PST) Date: Sun, 28 Nov 2021 21:47:38 +0100 From: raingloom To: pukkamustard Subject: Re: [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes) Message-ID: <20211128214738.2347f9e4@riseup.net> In-Reply-To: <20211122221308.685c9f11@riseup.net> References: <20211102065917.082a2e55@riseup.net> <86wnl9lcj3.fsf@posteo.net> <20211122221308.685c9f11@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_24_48=1.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: submit Cc: 51565@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On Mon, 22 Nov 2021 22:13:08 +0100 raingloom wrote: > On Mon, 15 Nov 2021 14:10:46 +0000 > pukkamustard wrote: > > > Thanks for this! > > > > Some minor changes may be needed to make the linter happy: > > > > raingloom writes: > > > > [..] > > > > > [3. text/x-patch; > > > 0002-gnu-Add-go-github-com-rivo-uniseg.patch]... > > > > Linter complains that a line is too long: > > > > gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg@0.2.0: > > line 8885 is way too long (93 characters) > > > > > > > > [4. text/x-patch; > > > 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]... > > > > Linter complains about the synopsis. Maybe: "Go functions for > > getting fixed width of characters or strings"? > > > > Does seem like a bit of a duplication of the description... > > > > > [5. text/x-patch; > > > 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]... > > > > > > [6. text/x-patch; > > > 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]... > > > > > > [7. text/x-patch; > > > 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]... > > > > Lines in descriptions are too long and should be wrapped. > > > > A synopsis is required. Maybe: "Ironwood is a Go network routing > > library using cryptographic keys as addresses"? > > Heck, I think I meant to run the linter but it was getting late and I > just wanted to be done with the patch. Well, here is an updated patch > list. Bump. Could someome merge this if everything is in order?