From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 14:04:32 2021 Received: (at 51538) by debbugs.gnu.org; 8 Nov 2021 19:04:32 +0000 Received: from localhost ([127.0.0.1]:59491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9wV-0002pl-Jf for submit@debbugs.gnu.org; Mon, 08 Nov 2021 14:04:32 -0500 Received: from lepiller.eu ([89.234.186.109]:38126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9wS-0002pY-Rb for 51538@debbugs.gnu.org; Mon, 08 Nov 2021 14:04:31 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7466d97d; Mon, 8 Nov 2021 19:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=fUlTImwpBU6w TMs81l+V/5+93SWUS3eLssWxXQr6XY0=; b=dgK5lBCMW/qTPIQMHkCU17gRQJCO 5NXimiHMDctp2jHV3W0CH8ZJoCewGt74a8HVO6NlTYKl3SqH5KAqUDtUZLAgfyuX BxWPDVehqRRbyXR2R9sILK8rAPVhz5aLYFJPPm2PWo9KZR442AVkuewm4bPxg3N0 1cYkMKUaNFcf1c5yuMV7d+5WE1YqdKy+Nrf5erfVCdEBVL+E8tW07RzQvf8bIC/s N3tFWx+5uzvCorStSNErzfNsoN4AJePtL1nq/UyAVSXRwkhQvZxkxXsjbRJ0s9Xy zfiAF9s69vTuqeWRv2Bfmwahx3SHCX5CNcAbikRHMonFstxH+ez3JL1Khg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6d6ce7af (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 8 Nov 2021 19:04:25 +0000 (UTC) Date: Mon, 08 Nov 2021 14:04:12 -0500 From: Julien Lepiller To: guix-patches@gnu.org, "pelzflorian (Florian Pelz)" , Disseminate Dissent Subject: =?US-ASCII?Q?Re=3A_=5Bbug=2351538=5D_First_Patch_Submit_Ever=3A?= =?US-ASCII?Q?_Additions_to_the_Cookbook_Documentation?= User-Agent: K-9 Mail for Android In-Reply-To: <20211108171850.q6pqyiv4g5q2oktr@pelzflorian.localdomain> References: <20211108171850.q6pqyiv4g5q2oktr@pelzflorian.localdomain> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51538 Cc: 51538@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think this is fine=2E The cookbook should recommend using Ctrl-L and sugg= est you can install clear with the ncurses package=2E We get that question = from time to time, so I think it belongs to a FAQ :) Le 8 novembre 2021 12:18:50 GMT-05:00, "pelzflorian (Florian Pelz)" a =C3=A9crit=C2=A0: >Disseminate, thank you for your work=2E > >On Mon, Nov 08, 2021 at 01:48:39PM +0000, Disseminate Dissent wrote: >> Thanks for the comments Florian, >>=20 >> Added periods and removed whitespace=2E >>=20 >> In my initial Guix setup I was unable to clear the terminal with >> neither `clear` nor C-l=2E Installing ncurses solved that issue and is >> listed as a dependency for GNU Readline=2E > >Bash always enables readline as far as I can see=2E Perhaps you used a >system that disabled C-l in the ~/=2Einputrc file, which would also >disable it for a Guix-installed bash? Some Slackware users complain >about non-working C-l on stackoverflow=2E Anyway I will leave this >patch for experienced guix commiters to decide; IMHO the clear command >should not be needed with Guix and the cookbook so far contains only >what can be done with Guix itself=2E Even though I like the idea of a >FAQ section and am happy about new Guix contributors such as you=2E > >As for the patch: > >On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-pa= tches via wrote: >> Corrected missing periods and whitespace=2E >> > >You have not addressed this latter passive Added instead of Add: > >On Mon, Nov 08, 2021 at 10:29:00AM +0100, pelzflorian (Florian Pelz) wrot= e: >> For the commit message, Guix uses the active voice =E2=80=9CAdd a FAQ s= ection >> with =E2=80=A6=E2=80=9D=2E >>=20 >>=20 >> > * doc/guix-cookbook=2Etexi: Added FAQ section=2E >>=20 >> Here too=2E > >Then: > >On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-pa= tches via wrote: >> @menu >> * Scheme tutorials:: Meet your new favorite language! >> -* Packaging:: Packaging tutorials >> -* System Configuration:: Customizing the GNU System >> +* Packaging:: Packaging tutorials=2E >> +* System Configuration:: Customizing the GNU System=2E >> * Advanced package management:: Power to the users! >> -* Environment management:: Control environment >> +* Environment management:: Control environment=2E >> +* FAQ:: Commonly asked questions=2E > >Your commit should only add the period to your sentence; other >sentences should remain untouched (fixing them belongs in a separate >commit)=2E I should fix such things myself in other commits; probably I >won=E2=80=99t do it=2E > >Other than that, it is a nicely written patch=2E > >It seems the issue when running the commands from >`info "(guix)Building from Git"` is that the other menu > >> +@menu >> +* How do I clear my terminal screen? >> +@end menu > >does not contain double colons followed by a sentence like the other >@menu=2E > >Regards, >Florian > > > > ------YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think this is fine=2E The cookbook should recomm= end using Ctrl-L and suggest you can install clear with the ncurses package= =2E We get that question from time to time, so I think it belongs to a FAQ = :)

Le 8 novembre 2021 12:18:50 GMT-05:00,= "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian=2Ede> a =C3=A9= crit=C2=A0:
Disseminate, thank you for your work=2E=


On Mon, Nov 08, 2021 at 01:48:39PM +0000, Disseminate Dissent wrote= :
Thanks for the commen= ts Florian,

Added periods and removed whitespace=2E

In my ini= tial Guix setup I was unable to clear the terminal with
neither `clear` = nor C-l=2E Installing ncurses solved that issue and is
listed as a depen= dency for GNU Readline=2E

Bash always enables readline = as far as I can see=2E Perhaps you used a
system that disabled C-l in t= he ~/=2Einputrc file, which would also
disable it for a Guix-installed b= ash? Some Slackware users complain
about non-working C-l on stackoverfl= ow=2E Anyway I will leave this
patch for experienced guix commiters to = decide; IMHO the clear command
should not be needed with Guix and the co= okbook so far contains only
what can be done with Guix itself=2E Even t= hough I like the idea of a
FAQ section and am happy about new Guix contr= ibutors such as you=2E

As for the patch:

On Mon, Nov 08, 2021= at 01:50:20PM +0000, Disseminate Dissent via Guix-patches via wrote:
Corrected missing periods a= nd whitespace=2E


You have not addressed this latter= passive Added instead of Add:

On Mon, Nov 08, 2021 at 10:29:00AM +0= 100, pelzflorian (Florian Pelz) wrote:
For the commit message, Guix uses the active voice =E2=80= =9CAdd a FAQ section
with =E2=80=A6=E2=80=9D=2E


* doc/guix-cookbook=2Etexi: Added FAQ s= ection=2E

Here too=2E

Then:

= On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-patc= hes via wrote:
@menu * Scheme tutorials:: Meet your new favorite language!
-* P= ackaging:: Packaging tutorials
-* System Configuration= :: Customizing the GNU System
+* Packaging:: Pa= ckaging tutorials=2E
+* System Configuration:: Customizing the GN= U System=2E
* Advanced package management:: Power to the users!
-* E= nvironment management:: Control environment
+* Environment manageme= nt:: Control environment=2E
+* FAQ:: Common= ly asked questions=2E

Your commit should only add the p= eriod to your sentence; other
sentences should remain untouched (fixing = them belongs in a separate
commit)=2E I should fix such things myself i= n other commits; probably I
won=E2=80=99t do it=2E

Other than tha= t, it is a nicely written patch=2E

It seems the issue when running t= he commands from
`info "(guix)Building from Git"` is that the other menu=

+@menu
+* How d= o I clear my terminal screen?
+@end menu

does not co= ntain double colons followed by a sentence like the other
@menu=2E
Regards,
Florian




------YS9O4FDVDMP6HDWL535UWDK16IITY8--