From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 15 06:01:26 2021 Received: (at 51346) by debbugs.gnu.org; 15 Nov 2021 11:01:26 +0000 Received: from localhost ([127.0.0.1]:52776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmZjp-0007vf-VP for submit@debbugs.gnu.org; Mon, 15 Nov 2021 06:01:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmZjo-0007vT-3o for 51346@debbugs.gnu.org; Mon, 15 Nov 2021 06:01:24 -0500 Received: from [2001:470:142:3::e] (port=57896 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmZji-0005Dj-L7; Mon, 15 Nov 2021 06:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NrTyhEKSsgMtIIvqVh6XYy1SRGQ+j4Y4Cq/je/OJCJQ=; b=EkceEgk8Ab3EIEBT2R2b TzYwKdWOubQBxMq451gsxSjc6pARlChWFfZ4Zbv522elKAzVq82GE70XBWuZeSF7Fix/nQ2nxE0x8 7M+gOHF/Jlgw/jTznwI3x3s4QCNTydMyNOSytsq0Ch3W4tArnR+cKidS7af5kjA3SJJI7jzBK/YA3 dylMPPIha7WkfGWe2eJydqo7vgWiOe3mX2Lve/yfoPezOJrFbCGnFa46lMMLBgMoPN9k1JxDlgkLF lG3C0ulDfD8SPNRWttfWi7/jESCQhdrSL0tqSy1O4PeUNqCoW/VDjeGRBiUgYZHYwZscnRSZvS47Y fYxiP2XxBXWt8g==; Received: from [193.50.110.110] (port=57554 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmZji-0002bx-4E; Mon, 15 Nov 2021 06:01:18 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Josselin Poiret Subject: Re: bug#51346: [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags References: <87tuh6ifwe.fsf@nckx> <20211027150913.6038-1-dev@jpoiret.xyz> <20211027150913.6038-5-dev@jpoiret.xyz> Date: Mon, 15 Nov 2021 12:01:15 +0100 In-Reply-To: <20211027150913.6038-5-dev@jpoiret.xyz> (Josselin Poiret's message of "Wed, 27 Oct 2021 15:09:13 +0000") Message-ID: <874k8d7kec.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 51346 Cc: Tobias Geerinckx-Rice , 51346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Josselin Poiret skribis: > * doc/guix.texi (operating-system Reference): Update swap-devices. > * doc/guix.texi (Swap Space): Add it. > * gnu/system/examples/desktop.tmpl: Add swap-devices example. [...] > +Here are some examples: > + > +@table @code > +@item (swap-space (target (uuid "4dab5feb-d176-45de-b287-9b0a6e4c01cb"))) > +Use the swap partition with the given UUID@. You can learn the UUID of a > +Linux swap partition by running @command{swaplabel @var{device}}, where > +@var{device} is the @file{/dev} file name of that partition. > + > +@item (swap-space (target (file-system-label "swap")) (dependencies (lis= t lvm-device))) Could you get rid of the table here, and instead write examples in @lisp blocks? Otherwise LGTM. Ludo=E2=80=99.