Hi Josselin, Josselin Poiret skribis: > Thanks for the review! Here is hopefully the last patchset, which > addresses most of the issues. > > I decided not to merge the doc changes with the first commit as it > also describes swap flags, but that's just a matter of taste I > suppose. > > Moved the deprecation warning that I originally put in > gnu/services/base.scm (swap-service) to a sanitizer of swap-devices in > its own commit, although it only reports the location of the > (operating-system) syntax use, not of the field itself (but that is > what I also noticed for other deprecation warnings, alas). I marked > the field as delayed, otherwise I was getting a lot of warnings while > testing rather than the only one I'm getting now. I suppose this can be addressed with this newfangled ‘define-with-syntax-properties’, right? :-) > Fixed the swap-device dependency filtering to silently ignore > old-style values rather than erroring out. > > Overall, I cleaned up all the rogue TABs I had inserted! > (setq-default indent-tabs-mode nil) for our Emacs readers at home. > This should not happen any more as I have set whitespace-mode to an > aggressive red highlighting for TAB characters. Nice. Note that ‘.dir-locals.el’ is supposed to set that; not sure why it didn’t work for you. > And finally, I changed the examples at the end to simply be @lisp > blocks, outside of a table. > > Josselin Poiret (5): > gnu: system: Rework swap space support, add dependencies. > gnu: system: Warn about swap-devices format change > gnu: system: Add swap flags. > gnu: system: Filter out boot dependencies from swap-space. > doc: Add new Swap Space section. Applied on ‘master’, which I plan to merge into ‘core-updates-frozen’ shortly. Thank you! Ludo’.