From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 18:07:10 2021 Received: (at 51122) by debbugs.gnu.org; 11 Oct 2021 22:07:10 +0000 Received: from localhost ([127.0.0.1]:32958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3Rt-000290-SO for submit@debbugs.gnu.org; Mon, 11 Oct 2021 18:07:10 -0400 Received: from lepiller.eu ([89.234.186.109]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma3Rq-00028o-B2 for 51122@debbugs.gnu.org; Mon, 11 Oct 2021 18:07:08 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7dba6dac; Mon, 11 Oct 2021 22:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=DeMwlJctWCW4 HUJjLaYjCmI6TgKWq/376wmDFCKj+Lc=; b=Py1MZY8kcI5OnfdO/deSYGoNylx0 MUId2X+EsssBSpdq3JicDrqaKYbEwdxZydT2OsDilrtKQ1qsIYyDtIe3+5nVuBWU 2o56z9SNElNUfuRvUJIf/8wyyeXHWZsD8HILI83BweSWO0n2tzy9uDQ/ucj3qmZQ mRqnjWywEt4osNIxRx/a5thDnBctlsQ2/s3AMJmrRgxHqQW2CLQsvX81uC1r2kvN pFTzFLr4YIsQPje8K7MvGEB3uAYXEMqDwH7D9Iz+OFgg4nL45PqaiyO6ajMJvh+3 Oeq6kvM+DsYbzOHYAV+qhZWculQRJN+qEzXZ5kMMSSVFLqtwThGcxFQt0w== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 67d722c0 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 11 Oct 2021 22:07:03 +0000 (UTC) Date: Tue, 12 Oct 2021 00:06:57 +0200 From: Julien Lepiller To: "pelzflorian (Florian Pelz)" Subject: Re: [bug#51122] [PATCH v2] maint: Factorize po xref translation. Message-ID: <20211012000657.11daa7a3@tachikoma.lepiller.eu> In-Reply-To: <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> References: <8a210e8ceaadfa600e60b0b97a1e7aba04b2bb02.1633901513.git.julien@lepiller.eu> <20211010233711.23bb1e9e@tachikoma.lepiller.eu> <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> <20211011144626.0049af43@tachikoma.lepiller.eu> <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51122 Cc: 51122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Mon, 11 Oct 2021 19:17:28 +0200, "pelzflorian (Florian Pelz)" a =C3=A9crit : > Thanks Julien! >=20 > On Mon, Oct 11, 2021 at 02:46:26PM +0200, Julien Lepiller wrote: > > Thanks for the quick review! I've updated the commit message and > > updated the copyright headers in guix/build/po.scm and > > guix/self.scm. =20 >=20 > In guix/self.scm you only removed code. I don=E2=80=99t think a copyright > header is needed there. Alright, I removed the copyright line on my side =20 >=20 > > I had to make the texi files depend on make-go because otherwise, I > > get messages like "guix/build/po.scm is newer than compiled > > .../guix/build/po.go" and it takes forever to build that file, once > > for each texi. For some reason, it's almost instantaneous when > > building in make-go. =20 >=20 > make-core-go instead of make-go is enough in my testing, but something > more fine-grained would save time. Also POXREF is run twice for each > guix.??.texi file. Maybe I did something wrong, maybe it is your > patch. Not sure. Testing takes long anyway. It only runs it once here, but there are three files to translate: guix.xx.texi, guix-cookbook.xx.texi and contributing.xx.texi. It looks like depending on make-go or make-core-go means we rebuild the texi files everytime we run "make", so that's not great :/. I'll see if I can isolate guix/build/po.scm (any ideas?). > Regards, > Florian