From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 02 11:40:45 2021 Received: (at submit) by debbugs.gnu.org; 2 Oct 2021 15:40:45 +0000 Received: from localhost ([127.0.0.1]:60334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWh7u-0006eQ-V5 for submit@debbugs.gnu.org; Sat, 02 Oct 2021 11:40:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:44608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWh7r-0006eG-Je for submit@debbugs.gnu.org; Sat, 02 Oct 2021 11:40:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWh7r-0000w2-BT for guix-patches@gnu.org; Sat, 02 Oct 2021 11:40:35 -0400 Received: from dustycloud.org ([50.116.34.160]:38558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWh7p-0001o6-I4; Sat, 02 Oct 2021 11:40:35 -0400 Received: from twig (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 06C562663C; Sat, 2 Oct 2021 11:40:31 -0400 (EDT) References: <20211002102116.27726-1-ludo@gnu.org> User-agent: mu4e 1.6.6; emacs 27.2 From: Christine Lemmer-Webber To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#50960] [PATCH 00/10] Add 'guix shell' to subsume 'guix environment' Date: Sat, 02 Oct 2021 09:03:34 -0400 In-reply-to: <20211002102116.27726-1-ludo@gnu.org> Message-ID: <87k0iv37eu.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=50.116.34.160; envelope-from=cwebber@dustycloud.org; helo=dustycloud.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 50960@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ludovic Court=C3=A8s writes: > Hello Guix! > > Here comes =E2=80=98guix shell=E2=80=99, a proposed replacement for =E2= =80=98guix environment=E2=80=99! > =E2=80=98guix environment=E2=80=99 would stay around though, at least for= some time, > probably for a long time. > > The differences to =E2=80=98guix environment=E2=80=99 are: > > 1. =E2=80=98--ad-hoc=E2=80=99 is the default. > > =E2=80=98guix shell hello=E2=80=99 =E2=89=8D =E2=80=98guix environ= ment --ad-hoc hello=E2=80=99 > =E2=80=98guix shell -D hello git=E2=80=99 =E2=89=8D =E2=80=98guix = environment hello --ad-hoc git=E2=80=99 > > 2. =E2=80=98guix shell=E2=80=99, without arguments, loads =E2=80=98guix= .scm=E2=80=99 or =E2=80=98manifest.scm=E2=80=99 > from the current directory or one of its ancestors. > > 3. =E2=80=98--load=E2=80=99/=E2=80=98-l=E2=80=99 is not =E2=80=98-f=E2= =80=99/=E2=80=98--install-from-file=E2=80=99 for consistency with > =E2=80=98guix package=E2=80=99. > > 4. =E2=80=98guix shell=E2=80=99 without arguments maintains a cache, su= ch that, the > second time you run it, it runs in ~0.1s (it does not even need to > connect to the daemon). > > If you run =E2=80=98guix pull=E2=80=99 and run again =E2=80=98guix s= hell=E2=80=99, it recomputes > the environment, as is currently the case with =E2=80=98guix environ= ment=E2=80=99. > > Here=E2=80=99s a summary of previous proposals: > > - Dave Thompson: https://lists.gnu.org/archive/html/guix-devel/2017-08/= msg00300.html > - [X] --ad-hoc is the default > - [X] caching > - [X] behavior with no arguments > - [ ] --load accepts > - [ ] Shepherd services > - [ ] 'guix environment --update' to explicitly update > - make --ad-hoc the default: https://issues.guix.gnu.org/38529 > - [X] https://issues.guix.gnu.org/38529#17: proposal for a new subcom= mand > deprecation of =E2=80=98guix environment=E2=80=99 > > I think records and Shepherd services could come later. > As for =E2=80=98--update=E2=80=99, I prefer the behavior implemented here= because it=E2=80=99s > stateless and thus more predictable. > > Thoughts? Are there other changes people would like to see? > > If there=E2=80=99s rough consensus I can work on v2 with documentation. = Please > let=E2=80=99s keep the discussion focused. :-) You have my massive thumbs up. Exciting stuff. > As for deprecation, I think there=E2=80=99s no rush. I imagine there cou= ld be > several phases, like: initially we only mention deprecation in the manual, > later on =E2=80=98guix environment=E2=80=99 starts emitting a warning, an= d later (I guess > at least two years later, probably more) we ask ourselves whether to > remove =E2=80=98guix environment=E2=80=99. At this point keeping it does= n=E2=80=99t cost us much. > > Thanks, > Ludo=E2=80=99. > > Ludovic Court=C3=A8s (10): > packages: Add 'package-development-inputs'. > profiles: Add 'package->development-manifest'. > DRAFT Add 'guix shell'. > DRAFT shell: By default load the local 'guix.scm' or 'manifest.scm' > file. > environment: Add tests for '--profile'. > environment: Skip derivation computation when '--profile' is used. > environment: Do not connect to the daemon when '--profile' is used. > environment: Autoload some modules. > cache: Gracefully handle non-existent cache. > shell: Maintain a profile cache. > > Makefile.am | 2 + > doc/guix.texi | 52 ++++++ > guix/cache.scm | 10 +- > guix/packages.scm | 10 ++ > guix/profiles.scm | 19 ++ > guix/scripts/environment.scm | 260 +++++++++++++++------------- > guix/scripts/shell.scm | 254 +++++++++++++++++++++++++++ > po/guix/POTFILES.in | 1 + > tests/guix-environment-container.sh | 8 + > tests/guix-environment.sh | 7 + > tests/guix-shell.sh | 70 ++++++++ > tests/packages.scm | 14 ++ > tests/profiles.scm | 7 + > 13 files changed, 594 insertions(+), 120 deletions(-) > create mode 100644 guix/scripts/shell.scm > create mode 100644 tests/guix-shell.sh