From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 29 19:14:54 2021 Received: (at 50814) by debbugs.gnu.org; 29 Sep 2021 23:14:54 +0000 Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVims-0002F5-EO for submit@debbugs.gnu.org; Wed, 29 Sep 2021 19:14:54 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:41180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVimq-0002Ew-K9 for 50814@debbugs.gnu.org; Wed, 29 Sep 2021 19:14:53 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id zzEq250080mfAB406zEqNf; Thu, 30 Sep 2021 01:14:50 +0200 Message-ID: Subject: Re: [bug#50814] [PATCH 5/5] guix: git-authenticate: Fix authenticate-repository. From: Maxime Devos To: Attila Lendvai , 50814@debbugs.gnu.org Date: Thu, 30 Sep 2021 01:14:44 +0200 In-Reply-To: <20210928162406.27205-5-attila@lendvai.name> References: <20210928162406.27205-1-attila@lendvai.name> <20210928162406.27205-5-attila@lendvai.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bw1GYLABH7zY1e7MLO6/" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1632957291; bh=lZHk8pZgUEyrOGgC/rByi1ZlvHRjWfnUx6VspRoW6fE=; h=Subject:From:To:Date:In-Reply-To:References; b=K7QBne2ZJrCe1D2FArpaknC5GsrTtpyyOPiKF+87kQTf72gzg1SiFZL03c3LfwGPx gBOC9af3FqgnLJEYkWsJi/vt3T7kJhiy40987COYyZBa8W1hIqzFh5YBEAgsiK0ZD0 95mMsFh2qXgCXcQRYfPKqh6o1lR341TlWOa1+1CMlorGWCHUOglSnxTa0VcEYbmLO4 1FM29V4frNCccOu0ac9xR4iTavE1y2bbUGT5kBBP7KYsM5Fo4pLXOtQjx6NqZhxkFx v7lrYWg17oWppw4zd36x2nSv78JhMI5hHWQM0hNMRSmmAc/Pw/eWT9B+SvxCQvnwve xsYzYT1moxFaA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50814 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-bw1GYLABH7zY1e7MLO6/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op di 28-09-2021 om 18:24 [+0200]: > [...] > -(define* (commit-authorized-keys repository commit > - #:optional (default-authorizations '())= ) > - "Return the list of OpenPGP fingerprints authorized to sign COMMIT, ba= sed on > -authorizations listed in its parent commits. If one of the parent commi= ts > -does not specify anything, fall back to DEFAULT-AUTHORIZATIONS." > +(define (authorized-keys-at-commit repository commit default-authorizati= ons) > + "Return the list of authorized key fingerprints from the '.guix-author= izations' > +file at the given commit." Could 'default-authorizations' still be documented? Anyway, I don't see any problems with this patch (ignoring the warning and = the docstrings), but I'm completely unfamiliar with the internals of channel authentication, so I don't know what to look for. You'll need to find some= one else to review this. Greetings, Maxime --=-bw1GYLABH7zY1e7MLO6/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYVTzZBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7r1sAPwPBMrVj2xf2/3+qRc2vCdJ99mL KGQv4vjiAmGOHRA6zAD9FPycoQ3VFncbi4+HCqt6WplEYsgLkw5Nneps9E4mYgU= =LpmA -----END PGP SIGNATURE----- --=-bw1GYLABH7zY1e7MLO6/--