From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 29 07:42:29 2021 Received: (at 50796) by debbugs.gnu.org; 29 Sep 2021 11:42:29 +0000 Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVXym-0001Mm-MF for submit@debbugs.gnu.org; Wed, 29 Sep 2021 07:42:28 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:55540 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVXyk-0001MX-MV for 50796@debbugs.gnu.org; Wed, 29 Sep 2021 07:42:27 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632915740; bh=EtseN51nB9zg8dnQHbY4+a7laxgnebkwo4cKxNIVsyM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=UGiR6DZo4GVUFEeyZZiE9b1tenFsxT/0PbZqyU9Qp4byxIIPeKhvt/BRJpukj7+Ne 9nXJMG8iWperYkwKpn6+MMIz+kWIr5GBdB1FB++LQUAZ3CRqoK4IXELXQNfvAHmMT2 W9JMXHgt7UE3Ay+xVVDWboN4N/bWy5bwtkApHKbI= To: Antero Mejr via Guix-patches via , 50796@debbugs.gnu.org Subject: Re: [bug#50796] [PATCH 1/2] gnu: Add libphonenumber. In-Reply-To: <20210928205649.27328-2-antero@mailbox.org> References: <20210928205649.27328-1-antero@mailbox.org> <20210928205649.27328-2-antero@mailbox.org> Date: Wed, 29 Sep 2021 13:42:15 +0200 Message-ID: <87wnmz1uco.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote: > * gnu/packages/telephony.scm (libphonenumber): New variable. > --- > gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/pa [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50796 Cc: Antero Mejr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote: > * gnu/packages/telephony.scm (libphonenumber): New variable. > --- > gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/pa [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote: > * gnu/packages/telephony.scm (libphonenumber): New variable. > --- > gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm > index 48bbe12920..50b5790ae3 100644 > --- a/gnu/packages/telephony.scm > +++ b/gnu/packages/telephony.scm > @@ -20,6 +20,7 @@ > ;;; Copyright =C2=A9 2020, 2021 Maxim Cournoyer > ;;; Copyright =C2=A9 2020 Vincent Legoll > ;;; Copyright =C2=A9 2021 LibreMiami > +;;; Copyright =C2=A9 2021 Antero Mejr > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -54,12 +55,14 @@ > #:use-module (gnu packages documentation) > #:use-module (gnu packages file) > #:use-module (gnu packages protobuf) > + #:use-module (gnu packages gawk) > #:use-module (gnu packages gettext) > #:use-module (gnu packages gl) > #:use-module (gnu packages glib) > #:use-module (gnu packages gnome) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages icu4c) > #:use-module (gnu packages image) > #:use-module (gnu packages libcanberra) > #:use-module (gnu packages linphone) > @@ -907,3 +910,38 @@ Initiation Protocol (SIP) and a multimedia framework= .") > telephony functionality into custom Telegram clients.") > (home-page "https://github.com/zevlg/libtgvoip") > (license license:unlicense))) > + > +(define-public libphonenumber > + (package > + (name "libphonenumber") > + (version "8.12.33") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/google/libphonenumber") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'enter-dir > + (lambda _ (chdir "cpp"))) > + (replace 'check > + (lambda _ (invoke "./libphonenumber_test")))))) Great that you got the tests to run; however this =E2=80=98check=E2=80=99 p= hase doesn=E2=80=99t respect the =E2=80=98--without-tests=E2=80=99 package transformation. The = snippet below should do. =2D-8<---------------cut here---------------start------------->8--- (lambda* (#:key tests? #:allow-other-keys) (when tests? (invoke "./libphonenumber_test"))) =2D-8<---------------cut here---------------end--------------->8--- > + (inputs > + `(("boost" ,boost) > + ("googletest" ,googletest) > + ("protobuf" ,protobuf) > + ("icu4c" ,icu4c))) > + (home-page "https://github.com/google/libphonenumber") > + (synopsis "C++ library for phone number parsing") > + (description > + "@code{libphonenumber} is Google's common Java, C++ and JavaScript > +library for parsing, formatting, and validating international phone numb= ers.") > + (license license:asl2.0))) For some reason the build is still not reproducible for me; I ran diffoscope on the two outputs, and it produced 120 MB worth of output=E2=80= =A6 Maybe a third person could test if the build is reproducible. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFUURcVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x54v0QAIyOlHGdy4ZlMXv282HZ89qE2eon mTSSgWqBV2KOlBrW4Y+PKpMWfRH9MvqFGM+PANohgXDbDJzHJWqu7QJB0e0izojn Bu7nDl+i0xH/SAu/A15/McV9fWGSbc3n2WFrG8xETYpY1aPpTjzAPcGlN6NlqHmX GWJ+VlCFx9n0f3IkbNtFvGLCi+i0upMGBLsQazzwB8duOdFrvpwgspilJaRH6Vt7 4uQW8MsvkAKhXAw0pZevcHMf1R87TM0Ttbthpqb+cze6yeAzp5dIbUqYoRyXVdZQ 5PrbJhrSbnL7cptDtstIeCupYF8pX5/RF00Rwn8XV/9uWgiHl1xpLrbdjvkRK/Yx k55hW8PiYYm2Mv9VfnKDi9ie+pLsbQnnnx8srWyV4av3kea6riTCrwD+z6a1DW/O pungg0hnQ0MVqtSSlIUgRXiTaHg0OfMXLySSBuQQchKw8rjZqQVqt+1kyX4y6aU8 f1ZcF/Bw6pSZsrLg5IxltpcmKEKhPUoHPhfOdx49TG0rg9QGzJeK/csyFjzWnwlK xLBbHybhww+SRUvDZwR62ZfN0CWn/V+LzsGu04676sJF48KWowP6/CTzV/RHlq1H ZAfdBQuyyPNwCdNoTdFvaSLitfkSKPOnXbI9jxe63u1OaZodtv92X3GUv58SS79B mRjmkcWz3ziR7w/S =kdgw -----END PGP SIGNATURE----- --=-=-=--