From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 14:50:29 2021 Received: (at 50756) by debbugs.gnu.org; 24 Sep 2021 18:50:29 +0000 Received: from localhost ([127.0.0.1]:59271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTqHF-0000ts-1p for submit@debbugs.gnu.org; Fri, 24 Sep 2021 14:50:29 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:48539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTmtg-0002ZR-1c for 50756@debbugs.gnu.org; Fri, 24 Sep 2021 11:13:58 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18OFDimU001902 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Sep 2021 11:13:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18OFDimU001902 From: Olivier Dion To: Xinglu Chen , Olivier Dion via Guix-patches via , 50756@debbugs.gnu.org Subject: Re: [bug#50756] [PATCH] gnu: Add lttng-tools. In-Reply-To: <87mto2jbkl.fsf@yoctocell.xyz> References: <20210923124004.3164-1-olivier.dion@polymtl.ca> <87mto2jbkl.fsf@yoctocell.xyz> Date: Fri, 24 Sep 2021 11:13:44 -0400 Message-ID: <87tuia2ehj.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Fri, 24 Sep 2021 15:13:44 +0000 X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 50756 X-Mailman-Approved-At: Fri, 24 Sep 2021 14:50:27 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On Fri, 24 Sep 2021, Xinglu Chen wrote: > On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote: >> +(define-public lttng-tools >> + (package >> + (name "lttng-tools") >> + (version "2.12.5") > > Version 2.13 is available; any reason for not using it? Would require to bump version of lttng-ust also I think. I prefer to do al= l of this in another patch.=20=20 >> + (arguments >> + `(#:tests? #f >> + #:parallel-tests? #f > > There is no need to set #:parallel-tests? if #:tests? is set to #f. During my testing, I noticed that test in parallel are not working because of how the lttng-daemon works. So I disable the parallel option in order to not forget it when testing will work in the future. I should probably add a comment to explain the rationale here. >> + (propagated-inputs >> + `(("libkmod" ,kmod) >> + ("modprobe" ,module-init-tools))) > > Any reason for the labels not being the same as the package? I follow the naming convention in the description of the project's README so it's easier to map the dependencies described by it to Guix's packages. I can change this, but I find it more clear that way. > >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("perl" ,perl) >> + ("libpfm4" ,libpfm4) >> + ("python" ,python-3) > > While running the configure script, I get > > configure: You may configure with --enable-python-bindings if you want = Python bindings. > > So you would have to pass the =E2=80=98--enable-python-bindings=E2=80=99 = flag, and > Python would be needed during runtime as well. Does it tho? Bindings can be generated at build time. While you would require python-3 at runtime to use the bindings, you don't require python-3 to use the other tools of the project. I don't mind adding it to the inputs, I'm just asking. > Could you send an updated patch? Will do soon! --=20 Olivier Dion Polymtl