From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 07:05:13 2021 Received: (at 50751) by debbugs.gnu.org; 24 Sep 2021 11:05:13 +0000 Received: from localhost ([127.0.0.1]:56768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTj0y-0002NU-OT for submit@debbugs.gnu.org; Fri, 24 Sep 2021 07:05:12 -0400 Received: from mail-4323.protonmail.ch ([185.70.43.23]:37582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTj0u-0002N6-BC for 50751@debbugs.gnu.org; Fri, 24 Sep 2021 07:05:10 -0400 Date: Fri, 24 Sep 2021 11:05:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1632481501; bh=WHpz5T91QzlmhNfU4iH/jEKEsCZEYOBwp7ci+9MDyj4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=KQ9QCRsiozKJtMLL+zKxNPni13zxXadSD+w3KiYY2LRj/pF3fp6TUYgtp+DDrtoVs C5vcj2zaLruD3aHEzcCzur5AhjazTH9JEj4l8dsMo6SgbAZhLZuebjlLYB3sQJb9J+ rRRTqgoPp2SJPRAYZTgUvmqs1e89uXbpcmHsLXDEzvSTdZBLMizJnSmdStdWWIIXpU p8cAPaBnHUZprtpbVErnVhFdirVsNuZylsZ03vSUsA+FBSHGX54LLJ4i/jPmKclpyG Y/Wwum+/1dXBGZvXOEYCs7TsqE3FhFV8hAxh0TBd/9D0iXTYzxFqNB8QEOwnDPXF7u YdvsdlztucdiQ== To: Sarah Morgensen From: Attila Lendvai Subject: Re: [bug#50751] [PATCH] gnu: update Trezor support Message-ID: In-Reply-To: <86mto3kumt.fsf@mgsn.dev> References: <20210923083045.10372-1-attila@lendvai.name> <86mto3kumt.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50751 Cc: 50751@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Fetch everything from their git repos, instead of pypi. > > Given the resulting version mismatch, and having to pick apart the > sources, is there a compelling reason for this? It looks like the same > files are included. an objective reason: one of these versions were not in pipy at the time i was working on this. a subjective reason: one less organization to rely on. if anything would happen to pipy, e.g. some random API change, then that wouldn't affect us anymore. if github went down or went hostile, then we could just change the git URL and continue with a minor glitch. > > - gnu/packages/finance.scm (python-trezor-agent): Update to 0.14.2. > > > > (python-trezor): Update to 0.12.3. > > (trezor-agent): Update to 0.11.0. > > (trezord): Update to 2.0.31. > > - gnu/packages/patches/trezor-agent-fix-argv0.patch: New file. > > When at all possible, version updates should be separate commits from cha= nges. ok, makes sense, because now that i think about it, it was broken with the prior version, too. i'll resend it in two patches once i have tested th= em. > > ;; overwrite the wrapper with the real thing. > > (install-file "./trezor_agent.py" > > - (string-append out "/bin")) > > - #t)))))) > > - (string-append out "/bin"))) > > - #t))))) > > This wasn't added by your patch, but it's odd that the reason for > overriding the wrapper wasn't documented.... i have added a comment explaining the situation. thank you for the feedback! the updated patches will be coming a bit later. - attila PGP:=C2=A05D5F 45C7 DFCD 0A39